Apply ILiteralOperation handling symmetrically to both pattern and options arguments

Copilot · stephentoub · Copilot · commit 9799eeaa0316 · 2025-06-19T21:21:29.000Z
Co-authored-by: stephentoub &lt;2642209+stephentoub@users.noreply.github.com&gt;
diff --git a/src/libraries/System.Text.RegularExpressions/gen/UpgradeToGeneratedRegexCodeFixer.cs b/src/libraries/System.Text.RegularExpressions/gen/UpgradeToGeneratedRegexCodeFixer.cs
@@ -303,13 +303,13 @@ static RegexOptions GetRegexOptionsFromArgument(ImmutableArray<IArgumentOperatio
                     // For patterns, let the normal logic below handle the formatting
                 }
 
-                // Handle literal operations for pattern
-                if (parameterName == UpgradeToGeneratedRegexAnalyzer.PatternArgumentName && argument.Value is ILiteralOperation literalOperation)
+                // Handle literal operations for both pattern and options
+                if (argument.Value is ILiteralOperation literalOperation)
                 {
                     return literalOperation.Syntax;
                 }
 
-                // Handle options
+                // Handle options that are not literal operations
                 if (parameterName == UpgradeToGeneratedRegexAnalyzer.OptionsArgumentName)
                 {
                     // For RegexOptions that are not constant field references, expand the value

Original file line number	Diff line number	Diff line change
`@@ -303,13 +303,13 @@ static RegexOptions GetRegexOptionsFromArgument(ImmutableArray<IArgumentOperatio`
`303`	`303`	`// For patterns, let the normal logic below handle the formatting`
`304`	`304`	`}`
`305`	`305`
`306`		`- // Handle literal operations for pattern`
`307`		`- if (parameterName == UpgradeToGeneratedRegexAnalyzer.PatternArgumentName && argument.Value is ILiteralOperation literalOperation)`
	`306`	`+ // Handle literal operations for both pattern and options`
	`307`	`+ if (argument.Value is ILiteralOperation literalOperation)`
`308`	`308`	`{`
`309`	`309`	`return literalOperation.Syntax;`
`310`	`310`	`}`
`311`	`311`
`312`		`- // Handle options`
	`312`	`+ // Handle options that are not literal operations`
`313`	`313`	`if (parameterName == UpgradeToGeneratedRegexAnalyzer.OptionsArgumentName)`
`314`	`314`	`{`
`315`	`315`	`// For RegexOptions that are not constant field references, expand the value`