Skip to content

Commit dda44e1

Browse files
authored
Disable some suspicious tests which might lead to OOM crashes on Android emulators and arm64 devices (#62767)
Just blindly disabling several crypto tests near which crashes have been observed for a while (based on a couple of the mobile targets rolling build runs). Disabled tests: - System.Security.Cryptography.Rsa.Tests.RSAKeyFileTests.ReadWriteDiminishedDPPrivatePkcs1 - System.Security.Cryptography.Rsa.Tests.RSAKeyFileTests.ReadEncryptedDiminishedDP_EmptyPassword - System.Security.Cryptography.Rsa.Tests.RSAKeyFileTests.DecryptPkcs12PbeTooManyIterations - System.Security.Cryptography.Rsa.Tests.RSAKeyFileTests.ReadWriteRsa2048EncryptedPkcs8_Pbes2HighIterations - System.Security.Cryptography.Dsa.Tests.DSAKeyFileTests.cs.DecryptPkcs12PbeTooManyIterations - System.Security.Cryptography.Dsa.TestsDSAKeyFileTests.cs.ReadWriteDsa1024EncryptedPkcs8_Pbes2HighIterations - System.Security.Cryptography.Tests.ECKeyFileTests.DecryptPkcs12PbeTooManyIterations - System.Security.Cryptography.Tests.ECKeyFileTests.ReadWriteEc256EncryptedPkcs8_Pbes2HighIterations - System.Security.Cryptography.EcDsa.Tests.ECDsaTests_Span See also #62547.
1 parent b338078 commit dda44e1

File tree

4 files changed

+9
-0
lines changed

4 files changed

+9
-0
lines changed

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -565,6 +565,7 @@ public static void DecryptPkcs12WithBytes()
565565
}
566566

567567
[Fact]
568+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
568569
public static void DecryptPkcs12PbeTooManyIterations()
569570
{
570571
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
@@ -585,6 +586,7 @@ public static void DecryptPkcs12PbeTooManyIterations()
585586
}
586587

587588
[Fact]
589+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
588590
public static void ReadWriteDsa1024EncryptedPkcs8_Pbes2HighIterations()
589591
{
590592
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -959,6 +959,7 @@ public void DecryptPkcs12WithBytes()
959959
}
960960

961961
[Fact]
962+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
962963
public void DecryptPkcs12PbeTooManyIterations()
963964
{
964965
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
@@ -976,6 +977,7 @@ public void DecryptPkcs12PbeTooManyIterations()
976977
}
977978

978979
[Fact]
980+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
979981
public void ReadWriteEc256EncryptedPkcs8_Pbes2HighIterations()
980982
{
981983
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
namespace System.Security.Cryptography.EcDsa.Tests
88
{
99
[SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")]
10+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
1011
public sealed class ECDsaTests_Span : ECDsaTests
1112
{
1213
protected override bool VerifyData(ECDsa ecdsa, byte[] data, int offset, int count, byte[] signature, HashAlgorithmName hashAlgorithm) =>

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public static void ReadWriteBigExponentPrivatePkcs1()
107107
}
108108

109109
[Fact]
110+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
110111
public static void ReadWriteDiminishedDPPrivatePkcs1()
111112
{
112113
ReadWriteBase64PrivatePkcs1(
@@ -789,6 +790,7 @@ public static void ReadPbes2Rc2EncryptedDiminishedDP_PasswordBytes()
789790
}
790791

791792
[Fact]
793+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
792794
public static void ReadEncryptedDiminishedDP_EmptyPassword()
793795
{
794796
// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Suppression approved. Unit test key.")]
@@ -1254,6 +1256,7 @@ public static void DecryptPkcs12WithBytes()
12541256
}
12551257

12561258
[Fact]
1259+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
12571260
public static void DecryptPkcs12PbeTooManyIterations()
12581261
{
12591262
// pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations
@@ -1290,6 +1293,7 @@ public static void DecryptPkcs12PbeTooManyIterations()
12901293
}
12911294

12921295
[Fact]
1296+
[ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)]
12931297
public static void ReadWriteRsa2048EncryptedPkcs8_Pbes2HighIterations()
12941298
{
12951299
// pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations

0 commit comments

Comments
 (0)