BrowserVersions.props

Author: pavelsavara

.github/workflows/bump-chrome-version.yml

@@ -27,7 +27,7 @@ jobs:
         run: >-
           make -C src/mono/wasm build-tasks &&
           PATH=$PWD/.dotnet:$PATH dotnet build eng/testing/bump-chrome-version.proj -p:Configuration=Release &&
-          git add eng/testing/ChromeVersions.props &&
+          git add eng/testing/BrowserVersions.props &&
           cat eng/testing/bump-chrome-pr.env >> "$GITHUB_ENV"
 
       - name: Check for changes

eng/pipelines/common/evaluate-default-paths.yml

@@ -7,7 +7,7 @@ parameters:
   _const_paths:
     _wasm_specific_only: [
         eng/testing/bump-chrome-version.proj
-        eng/testing/ChromeVersions.props
+        eng/testing/BrowserVersions.props
         eng/testing/WasmRunner*
         eng/testing/WasiRunner*
         eng/testing/scenarios/BuildWasiAppsJobsList.txt
@@ -58,7 +58,7 @@ parameters:
     ]
     _wasm_chrome: [
         eng/testing/bump-chrome-version.proj
-        eng/testing/ChromeVersions.props
+        eng/testing/BrowserVersions.props
     ]
     _perf_pipeline_specific_only: [
         eng/pipelines/runtime-wasm-perf.yml

eng/pipelines/runtime-wasm-perf.yml

@@ -16,7 +16,7 @@ pr:
     - eng/pipelines/coreclr/templates/run-perf*
     - eng/pipelines/coreclr/templates/run-scenarios-job.yml
     - eng/testing/performance/*
-    - eng/testing/ChromeVersions.props
+    - eng/testing/BrowserVersions.props
 
 variables:
   - template: /eng/pipelines/common/variables.yml

eng/testing/ChromeVersions.props renamed to eng/testing/BrowserVersions.props

@@ -3,7 +3,7 @@
   <Import Project="..\..\Directory.Build.props" />
   <UsingTask AssemblyFile="$(WasmBuildTasksAssemblyPath)" TaskName="Microsoft.WebAssembly.Build.Tasks.UpdateChromeVersions" />
   <PropertyGroup>
-    <ChromeVersionsPath>$(RepositoryEngineeringDir)testing\ChromeVersions.props</ChromeVersionsPath>
+    <ChromeVersionsPath>$(RepositoryEngineeringDir)testing\BrowserVersions.props</ChromeVersionsPath>
     <EnvVarsForPRPath>$(RepositoryEngineeringDir)testing\bump-chrome-pr.env</EnvVarsForPRPath>
   </PropertyGroup>
 

eng/testing/bump-chrome-version.proj

@@ -451,7 +451,7 @@ if [[ -n "$wasm_bundle_directory" ]]; then
 
         # get required version
         if [[ -z "$v8_version" ]]; then
-            v8_version=`grep linux_V8Version $source_directory/eng/testing/ChromeVersions.props | sed -e 's,.*>\([^\<]*\)<.*,\1,g' | cut -d. -f 1-3`
+            v8_version=`grep linux_V8Version $source_directory/eng/testing/BrowserVersions.props | sed -e 's,.*>\([^\<]*\)<.*,\1,g' | cut -d. -f 1-3`
             echo "V8 version: $v8_version"
         fi
         if [[ -z "$javascript_engine_path" ]]; then

eng/testing/performance/performance-setup.sh

@@ -19,7 +19,7 @@
     <WasmProvisionAfterTarget Condition="'$(WasmProvisionAfterTarget)' == ''">Build</WasmProvisionAfterTarget>
   </PropertyGroup>
 
-  <Import Project="$(MSBuildThisFileDirectory)ChromeVersions.props" />
+  <Import Project="$(MSBuildThisFileDirectory)BrowserVersions.props" />
 
   <PropertyGroup Condition="'$(BrowserHost)' != 'windows'">
     <FirefoxUrl>https://ftp.mozilla.org/pub/firefox/releases/$(linux_FirefoxRevision)/linux-x86_64/en-US/firefox-$(linux_FirefoxRevision).tar.bz2</FirefoxUrl>
@@ -100,7 +100,7 @@
     <Error Condition="!$([MSBuild]::IsOSPlatform('linux')) and !$([MSBuild]::IsOSPlatform('windows'))"
            Text="Chrome provisioning only supported on Linux, and windows." />
     <Error Condition="'$(ChromeVersion)' == ''"
-           Text="No %24(ChromeVersion) set. This can be set in eng/testing/ChromeVersions.props" />
+           Text="No %24(ChromeVersion) set. This can be set in eng/testing/BrowserVersions.props" />
 
     <RemoveDir Directories="$(ChromeDir)" />
 
@@ -128,7 +128,7 @@
     <Error Condition="!$([MSBuild]::IsOSPlatform('linux')) and !$([MSBuild]::IsOSPlatform('windows'))"
            Text="ChromeDriver provisioning only supported on Linux, and windows." />
     <Error Condition="'$(ChromeVersion)' == ''"
-           Text="No %24(ChromeVersion) set. This can be set in eng/testing/ChromeVersions.props" />
+           Text="No %24(ChromeVersion) set. This can be set in eng/testing/BrowserVersions.props" />
 
     <RemoveDir Directories="$(ChromeDriverDir)" />
 

eng/testing/wasm-provisioning.targets

@@ -362,18 +362,18 @@ npm update --lockfile-version=1
 
 Tests are run with V8, Chrome, node, and wasmtime for the various jobs.
 
-- V8: the version used is from `eng/testing/ChromeVersions.props`. This is used for all the library tests, and WBT, but *not* runtime tests.
+- V8: the version used is from `eng/testing/BrowserVersions.props`. This is used for all the library tests, and WBT, but *not* runtime tests.
 - Chrome: Same as V8.
 - Node: fixed version from emsdk
 - wasmtime - fixed version in `src/mono/wasi/wasi-sdk-version.txt`.
 
-### `eng/testing/ChromeVersions.props`
+### `eng/testing/BrowserVersions.props`
 
 This file is updated once a week by a github action `.github/workflows/bump-chrome-version.yml`, and the version is obtained by `src/tasks/WasmBuildTasks/GetChromeVersions.cs` task.
 
 # Perf pipeline
 
-- V8 version used to run the microbenchmarks is from `eng/testing/ChromeVersions.props`
+- V8 version used to run the microbenchmarks is from `eng/testing/BrowserVersions.props`
 
 TBD