Skip to content

Create a new test, instead of adding runtimeconfig.json to the existing Android functional test #50905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fanyang-mono opened this issue Apr 8, 2021 · 3 comments · Fixed by #58835
Assignees
Labels
area-Infrastructure-mono test-enhancement Improvements of test source code
Milestone

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Apr 8, 2021

Refer to #50612
Address the +1 comments from the above PR. (Addressed via #56486)
And add incremental build to the msbuild task. (Doc: https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-build-incrementally?view=vs-2019#to-specify-inputs-and-outputs-for-a-target)

@fanyang-mono fanyang-mono added the test-enhancement Improvements of test source code label Apr 8, 2021
@fanyang-mono fanyang-mono added this to the 6.0.0 milestone Apr 8, 2021
@fanyang-mono fanyang-mono self-assigned this Apr 8, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 8, 2021
@ghost
Copy link

ghost commented Apr 8, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Refer to #50612
Address the +1 comments from the above PR.
And add incremental build to the msbuild task. (Doc: https://docs.microsoft.com/en-us/visualstudio/msbuild/how-to-build-incrementally?view=vs-2019#to-specify-inputs-and-outputs-for-a-target)

Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-Infrastructure-mono, test enhancement, untriaged

Milestone: 6.0.0

@akoeplinger akoeplinger removed the untriaged New issue has not been triaged by the area owner label Apr 21, 2021
@SamMonoRT SamMonoRT modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@SamMonoRT
Copy link
Member

Moving to 7.0.0, test functionality already exists, this is more of a refactoring suggestion.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Sep 8, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Sep 9, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants