Skip to content

Support W3C Propagator #114583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
Merged

Support W3C Propagator #114583

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bfff305
Support W3C Propagator
tarekgh Apr 11, 2025
2f28655
Fix the comment
tarekgh Apr 12, 2025
53c9aba
Remove wrong assert
tarekgh Apr 12, 2025
9e40acc
try fix tracestate in http tests
tarekgh Apr 13, 2025
0e4e360
fix failure cases in the http tests
tarekgh Apr 13, 2025
d4ae01d
More http test fixes
tarekgh Apr 14, 2025
3c53587
fix typo in test
tarekgh Apr 14, 2025
7b07fef
Address the feedback
tarekgh Apr 15, 2025
25c20f6
Swap the comments
tarekgh Apr 15, 2025
ce3da09
Add baggage extraction test with correlation-context
tarekgh Apr 15, 2025
016c9bb
Address Miha's feedback
tarekgh Apr 15, 2025
18dc63d
Feedback
tarekgh Apr 16, 2025
a1317ee
Add the new exposed APIs
tarekgh Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...raries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ System.Diagnostics.DiagnosticSource</PackageDescription>
<Compile Include="System\Diagnostics\NoOutputPropagator.cs" />
<Compile Include="System\Diagnostics\PassThroughPropagator.cs" />
<Compile Include="System\Diagnostics\RandomNumberGenerator.cs" />
<Compile Include="System\Diagnostics\W3CPropagator.cs" />
<Compile Include="System\Diagnostics\Metrics\AggregationManager.cs" />
<Compile Include="System\Diagnostics\Metrics\Aggregator.cs" />
<Compile Include="System\Diagnostics\Metrics\AggregatorStore.cs" />
Expand Down
6 changes: 3 additions & 3 deletions ...ystem.Diagnostics.DiagnosticSource/src/System/Diagnostics/DistributedContextPropagator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ public static DistributedContextPropagator Current
/// </summary>
/// <remarks>
/// CreateDefaultPropagator will create a propagator instance that can inject and extract the headers with field names "tracestate",
/// "traceparent" of the identifiers which are formatted as W3C trace parent, "Request-Id" of the identifiers which are formatted as a hierarchical identifier.
/// The returned propagator can inject the baggage key-value pair list with header name "Correlation-Context" and it can extract the baggage values mapped to header names "Correlation-Context" and "baggage".
/// "traceparent" of the identifiers which are formatted as W3C trace parent.
/// The returned propagator can inject the baggage key-value pair list with header name "baggage" and it can extract the baggage values mapped to header name "baggage".
/// </remarks>
public static DistributedContextPropagator CreateDefaultPropagator() => LegacyPropagator.Instance;
public static DistributedContextPropagator CreateDefaultPropagator() => W3CPropagator.Instance;

/// <summary>
/// Returns a propagator which attempts to act transparently, emitting the same data on outbound network requests that was received on the in-bound request.
Expand Down
Loading
Loading