Skip to content

React to .NET 8 container tagging changes for targeting Windows Containers #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baronfel opened this issue Apr 7, 2023 · 1 comment
Closed
Labels
Area: Inference Changes to base image inference Priority: High

Comments

@baronfel
Copy link
Member

baronfel commented Apr 7, 2023

From 8.0 preview 3, the .NET containers tagging scheme has changed - the multi-platform images no longer have windows platforms. The details are here.

Concretely, this means that we need to infer one of the 'concrete' windows container tags when the RID is win-x64. The windows tags that are available are:

  • 8.0.0-preview.2-windowsservercore-ltsc2022
  • 8.0.0-preview.2-windowsservercore-1809
  • 8.0.0-preview.2-nanoserver-ltsc2022
  • 8.0.0-preview.2-nanoserver-1809

We should bias to more minimal Windows images, so we should infer one of the nanoserver tags. We should add the following decision to our tag inference scheme:

if TARGET RID is win-x64
  if CURRENT SDK RID is win-x64
    use the windows OS version to choose what windows tag should be used:
		if the windows version is >= 10.0.20348 then `nanoserver-ltsc2022`
		else if the windows version is >= 10.0.17763  then `nanoserver-1809`
		else fail
  else
    since we're on a non-windows OS we just assume the more recent nanoserver tag, `nanoserver-ltsc2022`
@baronfel
Copy link
Member Author

We're not going to do this since we no longer infer windows base image names by default (per the change the dotnet-docker team made to the .NET images). If a user wants to use Windows containers they must specify a base image explicitly.

@baronfel baronfel closed this as not planned Won't fix, can't repro, duplicate, stale Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Inference Changes to base image inference Priority: High
Projects
None yet
Development

No branches or pull requests

1 participant