Add unit test for GetAllRuntimeIdentifiers

Author: nguerrera

test/Microsoft.NET.Build.Tests/GivenThatWeWantToBuildACrossTargetedLibrary.cs

@@ -8,6 +8,9 @@
 using Microsoft.NET.TestFramework.Commands;
 using Xunit;
 using static Microsoft.NET.TestFramework.Commands.MSBuildTest;
+using System.Xml.Linq;
+using System.Linq;
+using FluentAssertions;
 
 namespace Microsoft.NET.Build.Tests
 {
@@ -79,5 +82,55 @@ public void It_builds_desktop_library_successfully_on_windows()
                 "netstandard1.5/DesktopAndNetStandard.deps.json"
             });
         }
+
+        [Theory]
+        [InlineData("1", "win7-x86", "win7-x86;win7-x64", "win10-arm", "win7-x86;linux;WIN7-X86;unix", "osx-10.12", "win8-arm;win8-arm-aot",
+            "win7-x86;win7-x64;win10-arm;linux;unix;osx-10.12;win8-arm;win8-arm-aot")]
+        public void It_combines_inner_rids_for_restore(
+            string identifier,
+            string outerRid,
+            string outerRids,
+            string firstFrameworkRid,
+            string firstFrameworkRids,
+            string secondFrameworkRid,
+            string secondFrameworkRids,
+            string expectedCombination)
+        {
+
+            if (UsingFullFrameworkMSBuild)
+            {
+                // Remove when Jenkins has desktop msbuild without import of Microsoft.NuGet.targets
+                // https://github.com/dotnet/sdk/issues/874
+                expectedCombination += ";win;win-x86;win-x64";
+            }
+
+            var testAsset = _testAssetsManager
+                .CopyTestAsset(Path.Combine("CrossTargeting", "NetStandardAndNetCoreApp"), identifier: identifier)
+                .WithSource()
+                .WithProjectChanges(project =>
+                {
+                    var ns = project.Root.Name.Namespace;
+                    var propertyGroup = project.Root.Elements(ns + "PropertyGroup").First();
+
+                    propertyGroup.Add(
+                        new XElement(ns + "RuntimeIdentifier", outerRid),
+                        new XElement(ns + "RuntimeIdentifiers", outerRids));
+
+                    propertyGroup.AddAfterSelf(
+                        new XElement(ns + "PropertyGroup",
+                            new XAttribute(ns + "Condition", "'$(TargetFramework)' == 'netstandard1.5'"),
+                            new XElement(ns + "RuntimeIdentifier", firstFrameworkRid),
+                            new XElement(ns + "RuntimeIdentifiers", firstFrameworkRids)),
+                        new XElement(ns + "PropertyGroup",
+                            new XAttribute(ns + "Condition", "'$(TargetFramework)' == 'netcoreapp1.0'"),
+                            new XElement(ns + "RuntimeIdentifier", secondFrameworkRid),
+                            new XElement(ns + "RuntimeIdentifiers", secondFrameworkRids)));
+                });
+
+            var command = new GetValuesCommand(Stage0MSBuild, testAsset.TestRoot, "", valueName: "RuntimeIdentifiers");
+            command.DependsOnTargets = "GetAllRuntimeIdentifiers";
+            command.Execute().Should().Pass();
+            command.GetValues().Should().BeEquivalentTo(expectedCombination.Split(';'));
+        }
     }
 }

test/Microsoft.NET.TestFramework/Commands/GetValuesCommand.cs

@@ -24,6 +24,8 @@ public enum ValueType
 
         public bool ShouldCompile { get; set; } = true;
 
+        public string DependsOnTargets { get; set; } = "Compile";
+
         public string Configuration { get; set; }
 
         public GetValuesCommand(MSBuildTest msbuild, string projectPath, string targetFramework,
@@ -58,7 +60,7 @@ public override CommandResult Execute(params string[] args)
   <PropertyGroup>
     <MSBuildAllProjects>$(MSBuildAllProjects);$(MSBuildThisFileFullPath)</MSBuildAllProjects>
   </PropertyGroup>
-  <Target Name=`WriteValuesToFile` " + (ShouldCompile ? "DependsOnTargets=`Compile`" : "") + $@">
+  <Target Name=`WriteValuesToFile` " + (ShouldCompile ? $"DependsOnTargets=`{DependsOnTargets}`" : "") + $@">
     <WriteLinesToFile
       File=`bin\$(Configuration)\$(TargetFramework)\{_valueName}Values.txt`
       {linesAttribute}