Skip to content

Commit 47c8e29

Browse files
SimaTianCopilot
andcommitted
Fix CWD race: add [Collection] to serialize CWD-mutating tests
Parity tests that call Directory.SetCurrentDirectory() race with each other when xUnit runs test classes in parallel. Adding [Collection("CWD-Dependent")] serializes these 4 test classes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent a1d9cfc commit 47c8e29

4 files changed

Lines changed: 8 additions & 0 deletions

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAProcessFrameworkReferencesMultiThreading.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
namespace Microsoft.NET.Build.Tasks.UnitTests
1212
{
13+
[Collection("CWD-Dependent")]
14+
1315
public class GivenAProcessFrameworkReferencesMultiThreading
1416
{
1517
[Fact]

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAResolveRuntimePackAssetsMultiThreading.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
namespace Microsoft.NET.Build.Tasks.UnitTests
1212
{
13+
[Collection("CWD-Dependent")]
14+
1315
public class GivenAResolveRuntimePackAssetsMultiThreading
1416
{
1517
[Fact]

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAResolveTargetingPackAssetsMultiThreading.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
namespace Microsoft.NET.Build.Tasks.UnitTests
1212
{
13+
[Collection("CWD-Dependent")]
14+
1315
public class GivenAResolveTargetingPackAssetsMultiThreading
1416
{
1517
[Fact]

src/Tasks/Microsoft.NET.Build.Tasks.UnitTests/GivenAShowMissingWorkloadsMultiThreading.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
namespace Microsoft.NET.Build.Tasks.UnitTests
1212
{
13+
[Collection("CWD-Dependent")]
14+
1315
public class GivenAShowMissingWorkloadsMultiThreading
1416
{
1517
[Fact]

0 commit comments

Comments
 (0)