Skip to content

Add build parameter to specify default TargetLatestAspNetCoreRuntimePatch value (source-build) #9493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagood opened this issue Jun 12, 2018 · 2 comments
Labels
needs team triage Requires a full team discussion
Milestone

Comments

@dagood
Copy link
Member

dagood commented Jun 12, 2018

Helps fix dotnet/source-build#586. (Read the description for why we need to be able to set a default specific to source-build.)

A way I saw to do this is: dagood/cli@4b89017 (using Microsoft.NETCoreSdk.BundledVersions.props to carry a source-build default value for TargetLatestAspNetCoreRuntimePatch). I don't know if it fits what the file's for.

@livarcocc does that look reasonable, or would you suggest something else?

/cc @tmds @natemcmaster

@natemcmaster
Copy link
Contributor

natemcmaster commented Jun 12, 2018

We would also need to make changes in aspnet/websdk (cc @vijayrkn @JunTaoLuo )

See https://github.com/dotnet/cli/issues/9469

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 5.0.1xx milestone Jan 31, 2020
@marcpopMSFT marcpopMSFT added the untriaged Request triage from a team member label Apr 16, 2020
@sfoslund sfoslund added needs team triage Requires a full team discussion and removed untriaged Request triage from a team member labels Apr 20, 2020
@sfoslund sfoslund removed their assignment Apr 20, 2020
@marcpopMSFT
Copy link
Member

Create a new bug if we hit issues during the 5.0 pass for source build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs team triage Requires a full team discussion
Projects
None yet
Development

No branches or pull requests

5 participants