Skip to content

Remove OverrideBootstrapVersions.props after 7.0.1 release #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crummel opened this issue Nov 17, 2022 · 4 comments · Fixed by dotnet/sdk#45550
Closed

Remove OverrideBootstrapVersions.props after 7.0.1 release #3129

crummel opened this issue Nov 17, 2022 · 4 comments · Fixed by dotnet/sdk#45550
Assignees
@MichaelSimons
Labels
area-build Improvements in source-build's own build process

Comments

@crummel
Copy link
Contributor

crummel commented Nov 17, 2022 •
edited
Loading

For 7.0.1 we added a file eng/bootstrap/OverrideBootstrapVersions.props that allows us to fix an issue with some package versions in runtime. This file can and should be removed after the 7.0.1 release.

  • eng/bootstrap/buildBootstrapPreviouslySB.csproj also needs to be updated as it currently unconditionally copies OverrideBootstrapProps to PVP even when the file doesn't exist.
@ghost
Copy link

ghost commented Nov 17, 2022

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged label Nov 17, 2022
@crummel crummel added the area-build Improvements in source-build's own build process label Nov 17, 2022
@MichaelSimons MichaelSimons moved this to 8.0 On Deck in .NET Source Build Dec 1, 2022
@MichaelSimons
Copy link
Member

[Triage] This is needed until #3146 is addressed.

@MichaelSimons MichaelSimons moved this from 8.0 On Deck to Servicing On Deck in .NET Source Build Dec 12, 2022
@crummel crummel mentioned this issue Feb 3, 2023
Merged
@crummel crummel moved this from Servicing On Deck to In Progress in .NET Source Build Mar 10, 2023
@crummel crummel moved this from In Progress to Blocked in .NET Source Build Mar 10, 2023
@crummel
Copy link
Contributor Author

crummel commented Mar 10, 2023

I have a change ready for this once the new PSB package goes in.

@MichaelSimons MichaelSimons moved this from Blocked to Servicing On Deck in .NET Source Build Apr 3, 2023
@MichaelSimons MichaelSimons moved this from Servicing On Deck to Blocked in .NET Source Build Apr 3, 2023
@MichaelSimons
Copy link
Member

This is now blocked on dotnet/runtime#81487.

@MichaelSimons MichaelSimons self-assigned this Dec 18, 2024
@MichaelSimons MichaelSimons moved this from Blocked to In Progress in .NET Source Build Dec 18, 2024
@MichaelSimons MichaelSimons mentioned this issue Dec 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Source Build Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelSimons MichaelSimons

Labels
area-build Improvements in source-build's own build process
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused OverrideBootstrapVersions infrastructure MichaelSimons/sdk
2 participants
@crummel @MichaelSimons