[VMR] nuget-client build fails on case-preserving filesystems (Mac, Windows)

[directhex]

On Linux, NuGet.config and NuGet.Config are different files. Both can exist in the same folder, and attempts to read the "wrong" file will result in a file not found error. As a result, we have a patch in the NuGet repo, eng/source-build-patches/0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch authored by @crummel, to reconcile a bad casing assumption. However, on Windows and Mac, this patch fails to apply with git apply as those two filenames are considered equivalent. This breaks the build on non-Linux.

We either need a way to separate out source build patches by OS applicability (e.g. eng/source-build-patches/$(TargetOS)/), or need to eliminate the patch.

[MichaelSimons]

[Triage] A fix was accepted in Arcade to address the problem that required the patch. We believe the source-build patch can now be removed.

[directhex]

Is there a plan to remove the patch from the nuget-client repo? This is still causing build failures on non-Linux:

    Check for patches in /Users/directhex/Projects/dotnet/src/nuget-client/eng/source-build/../../eng/source-build-patches/*.patch
  EXEC : error : NuGet.config: already exists in working directory [/Users/directhex/Projects/dotnet/src/nuget-client/eng/source-build/source-build.proj]
  /Users/directhex/Projects/dotnet/src/nuget-client/eng/source-build/source-build.proj(59,5): error MSB3073: The command "git --work-tree=/Users/directhex/Projects/dotnet/src/nuget-client/eng/source-build/../../ apply --ignore-whitespace --whitespace=nowarn --unsafe-paths "/Users/directhex/Projects/dotnet/src/nuget-client/eng/source-build-patches/0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch"" exited with code 1.

[MichaelSimons]

Is there a plan to remove the patch from the nuget-client repo? This is still causing build failures on non-Linux:

Yes, that is what we intend to do with this issue.

[directhex]

@MichaelSimons what's the status on getting this resolved in nuget-client.git? This patch continues to break building on case-preserving filesystems (i.e. breaks Windows & Mac builds of the VMR)

[MichaelSimons]

Taking a brief look, I don't think this is necessary anymore. I just ran a full vmr build to confirm. I will check a few more things and then open a PR to remove this.

[MichaelSimons]

Alright I think I found the fix that eliminated the need for this patch - dotnet/arcade#7549. I will open a PR to remove this.

[directhex]

OK. I can send a PR to NuGet.Client to remove https://github.com/NuGet/NuGet.Client/blob/dev/eng/source-build-patches/0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch

[MichaelSimons]

OK. I can send a PR to NuGet.Client to remove https://github.com/NuGet/NuGet.Client/blob/dev/eng/source-build-patches/0001-Rename-NuGet.Config-to-NuGet.config-to-account-for-a.patch

I just opened NuGet/NuGet.Client#5414

[MichaelSimons]

This patch has been removed and flowed into the VMR.