Skip to content

Disable signing in NuGet.Client rather than providing our own key in multiple parameters #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dagood opened this issue Jul 13, 2018 · 0 comments
Open

Disable signing in NuGet.Client rather than providing our own key in multiple parameters #647

dagood opened this issue Jul 13, 2018 · 0 comments
Labels
area-upstream-fix Needs a change in a contributing repo

Comments

@dagood
Copy link
Member

dagood commented Jul 13, 2018

source-build/repos/nuget-client.proj

Lines 19 to 20 in 4ca4d03

<EnvironmentVariables Include="MS_PFX_PATH=$(NuGetKeyFilePath)" />
<EnvironmentVariables Include="NUGET_PFX_PATH=$(NuGetKeyFilePath)" />

#646 (comment)

[@crummel] Yeah, there's now two different variables used for the PFX path, we will attempt to delay-sign and fail without this. I can look at whether we can disable signing entirely, that seems like the better option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-upstream-fix Needs a change in a contributing repo
Projects
.NET Source Build
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dseefeld @MichaelSimons @dagood