Skip to content

Commit 648ca00

Browse files
committed
add more comments
1 parent e8e1b00 commit 648ca00

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/csharp/Microsoft.Spark/Utils/AssemblyLoader.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ internal static Assembly ResolveAssembly(string assemblyName)
7979
string simpleAsmName = new AssemblyName(assemblyName).Name;
8080
foreach (string extension in s_extensions)
8181
{
82-
var assemblyFileName = $"{simpleAsmName}{extension}";
82+
string assemblyFileName = $"{simpleAsmName}{extension}";
8383
if (TryLoadAssembly(assemblyFileName, ref assembly))
8484
{
8585
s_assemblyCache[assemblyName] = assembly;
@@ -96,6 +96,12 @@ internal static Assembly ResolveAssembly(string assemblyName)
9696
/// 1) The working directory
9797
/// 2) The directory of the application
9898
/// </summary>
99+
/// <remarks>
100+
/// The probing order is important in cases when spark is launched on
101+
/// YARN. The executors are run inside 'containers' and files that are passed
102+
/// via 'spark-submit --files' will be pushed to these 'containers'. This path
103+
/// is the working directory and the 1st probing path that will be checked.
104+
/// </remarks>
99105
/// <param name="assemblyFileName">Name of the file that contains the assembly</param>
100106
/// <param name="assembly">The loaded assembly.</param>
101107
/// <returns>True if assembly is loaded, false otherwise.</returns>

0 commit comments

Comments
 (0)