Remove cohosting setting and hardcode the value to true (#8810)

Author: phil-allen-msft

.vscode/launch.json

@@ -97,33 +97,6 @@
             "preLaunchTask": "packageDev",
             "internalConsoleOptions": "openOnSessionStart"
         },
-        {
-            "name": "[Razor] Run Current File Integration Test",
-            "type": "extensionHost",
-            "request": "launch",
-            "runtimeExecutable": "${execPath}",
-            "args": [
-                // Launch VSCode using a specific profile to ensure that user settings are not used.
-                // This profile must be imported into vscode before running this launch configuration.
-                // The profile can be found under /test/csharp-test-profile.
-                "--profile",
-                "csharp-test-profile",
-                "${workspaceRoot}/test/razor/razorIntegrationTests/testAssets/RazorApp/.vscode/devkit_RazorApp.code-workspace",
-                "--extensionDevelopmentPath=${workspaceRoot}",
-                "--extensionTestsPath=${workspaceRoot}/out/test/razor/razorIntegrationTests",
-                "--log",
-                "ms-dotnettools.csharp:trace"
-            ],
-            "env": {
-                "CODE_EXTENSIONS_PATH": "${workspaceRoot}",
-                "TEST_FILE_FILTER": "${file}"
-            },
-            "sourceMaps": true,
-            "outFiles": ["${workspaceRoot}/dist/*.js", "${workspaceRoot}/out/test/**/*.js"],
-            "resolveSourceMapLocations": ["${workspaceFolder}/**", "!**/node_modules/**"],
-            "preLaunchTask": "packageDev",
-            "internalConsoleOptions": "openOnSessionStart"
-        },
         {
             "name": "[Razor Cohost] Run Current File Integration Test",
             "type": "extensionHost",
@@ -248,15 +221,6 @@
             "args": ["generateOptionsSchema"],
             "cwd": "${workspaceFolder}"
         },
-        {
-            "type": "node",
-            "request": "launch",
-            "name": "Razor integration tests",
-            "preLaunchTask": "build",
-            "program": "${workspaceFolder}/node_modules/gulp/bin/gulp.js",
-            "args": ["test:integration:razor"],
-            "cwd": "${workspaceFolder}"
-        },
         {
             "type": "node",
             "request": "launch",

CHANGELOG.md

@@ -5,6 +5,7 @@
 
 # 2.103.x
 * Fix indentation after pressing Enter in Razor files (PR: [#8809](https://github.com/dotnet/vscode-csharp/pull/8809))
+* Remove non-cohosting editor code (PR: [#8810](https://github.com/dotnet/vscode-csharp/pull/8810))
 
 # 2.102.x
 * Update Roslyn to 5.3.0-2.25568.9 (PR: [#8799](https://github.com/dotnet/vscode-csharp/pull/8799))

l10n/bundle.l10n.json

@@ -67,26 +67,9 @@
   "Replace existing build and debug assets?": "Replace existing build and debug assets?",
   "Could not locate .NET Core project in '{0}'. Assets were not generated.": "Could not locate .NET Core project in '{0}'. Assets were not generated.",
   "Unable to generate assets to build and debug. {0}.": "Unable to generate assets to build and debug. {0}.",
-  "Cannot load Razor language server because the directory was not found: '{0}'": "Cannot load Razor language server because the directory was not found: '{0}'",
+  "Cannot load Razor OmniSharp language server because the directory was not found: '{0}'": "Cannot load Razor OmniSharp language server because the directory was not found: '{0}'",
   "Razor Log": "Razor Log",
   "Could not find '{0}' in or above '{1}'.": "Could not find '{0}' in or above '{1}'.",
-  "Could not find Razor Language Server executable '{0}' within directory": "Could not find Razor Language Server executable '{0}' within directory",
-  "Server failed to start after retrying 5 times.": "Server failed to start after retrying 5 times.",
-  "Razor Language Server failed to start unexpectedly, please check the 'Razor Log' and report an issue.": "Razor Language Server failed to start unexpectedly, please check the 'Razor Log' and report an issue.",
-  "Tried to send requests while server is not started.": "Tried to send requests while server is not started.",
-  "Tried to bind on request logic while server is not started.": "Tried to bind on request logic while server is not started.",
-  "Tried to bind on notification logic while server is not started.": "Tried to bind on notification logic while server is not started.",
-  "Cannot stop Razor Language Server as it is already stopped.": "Cannot stop Razor Language Server as it is already stopped.",
-  "Razor Language Server failed to stop correctly, please check the 'Razor Log' and report an issue.": "Razor Language Server failed to stop correctly, please check the 'Razor Log' and report an issue.",
-  "Razor HTML Preview": "Razor HTML Preview",
-  "Unexpected error when attaching to HTML preview window.": "Unexpected error when attaching to HTML preview window.",
-  "Razor HTML copied to clipboard": "Razor HTML copied to clipboard",
-  "Report a Razor issue": "Report a Razor issue",
-  "Host document file path": "Host document file path",
-  "Virtual document file path": "Virtual document file path",
-  "Copy Html": "Copy Html",
-  "Token cancellation requested: {0}": "Token cancellation requested: {0}",
-  "Synchronization timed out": "Synchronization timed out",
   "Report Razor Issue": "Report Razor Issue",
   "Unexpected error when attaching to report Razor issue window.": "Unexpected error when attaching to report Razor issue window.",
   "You must first start the data collection before copying.": "You must first start the data collection before copying.",
@@ -104,6 +87,7 @@
   "Privacy Alert! The contents copied to your clipboard may contain personal data. Prior to posting to GitHub, please remove any personal data which should not be publicly viewable.": "Privacy Alert! The contents copied to your clipboard may contain personal data. Prior to posting to GitHub, please remove any personal data which should not be publicly viewable.",
   "Copy issue content again": "Copy issue content again",
   "Cannot start collecting Razor logs when {0} is set to {1}. Please open the output window, choose the \"Razor Log\", and use the gear icon to ensure the log level is set to \"Debug\" or \"Trace\".": "Cannot start collecting Razor logs when {0} is set to {1}. Please open the output window, choose the \"Razor Log\", and use the gear icon to ensure the log level is set to \"Debug\" or \"Trace\".",
+  "Report a Razor issue": "Report a Razor issue",
   "Non Razor file as active document": "Non Razor file as active document",
   "Could not determine CSharp content": "Could not determine CSharp content",
   "Could not determine Html content": "Could not determine Html content",
@@ -128,20 +112,10 @@
   "Razor.VSCode version": "Razor.VSCode version",
   "VSCode version": "VSCode version",
   "Extensions": "Extensions",
-  "Projected CSharp as seen by extension": "Projected CSharp as seen by extension",
-  "Unable to resolve VSCode's version of CSharp": "Unable to resolve VSCode's version of CSharp",
-  "Projected Html as seen by extension": "Projected Html as seen by extension",
-  "Unable to resolve VSCode's version of Html": "Unable to resolve VSCode's version of Html",
   "Unable to find Razor extension version.": "Unable to find Razor extension version.",
   "Extension": "Extension",
   "Author": "Author",
   "Version": "Version",
-  "Razor C# Preview": "Razor C# Preview",
-  "Unexpected error when attaching to C# preview window.": "Unexpected error when attaching to C# preview window.",
-  "Razor C# copied to clipboard": "Razor C# copied to clipboard",
-  "Copy C#": "Copy C#",
-  "1 reference": "1 reference",
-  "{0} references": "{0} references",
   "Run and Debug: auto-detection found {0} for a launch browser": "Run and Debug: auto-detection found {0} for a launch browser",
   "There was an unexpected error while launching your debugging session. Check the console for helpful logs and visit the debugging docs for more info.": "There was an unexpected error while launching your debugging session. Check the console for helpful logs and visit the debugging docs for more info.",
   "View Debug Docs": "View Debug Docs",

package.json

@@ -72,7 +72,6 @@
     "compile:razorTextMate": "npx js-yaml src/razor/syntaxes/aspnetcorerazor.tmLanguage.yml > src/razor/syntaxes/aspnetcorerazor.tmLanguage.json",
     "test:unit": "npm run compileDev && gulp test:unit",
     "test:integration:csharp": "npm run packageDev && gulp test:integration:csharp",
-    "test:integration:razor": "npm run packageDev && gulp test:integration:razor",
     "test:integration:razor:cohost": "npm run packageDev && gulp test:integration:razor:cohost",
     "test:integration:devkit": "npm run packageDev && gulp test:integration:devkit",
     "test:integration:untrusted": "npm run packageDev && gulp test:integration:untrusted",
@@ -1447,10 +1446,6 @@
               "razorExtension": {
                 "description": "%configuration.dotnet.server.componentPaths.razorExtension%",
                 "type": "string"
-              },
-              "razorDevKit": {
-                "description": "%configuration.dotnet.server.componentPaths.razorDevKit%",
-                "type": "string"
               }
             },
             "default": {}
@@ -1542,14 +1537,6 @@
             "type": "boolean",
             "default": true,
             "description": "%configuration.razor.languageServer.suppressLspErrorToasts%"
-          },
-          "razor.languageServer.cohostingEnabled": {
-            "type": "boolean",
-            "default": true,
-            "description": "%configuration.razor.languageServer.cohostingEnabled%",
-            "tags": [
-              "experimental"
-            ]
           }
         }
       },

package.nls.cs.json

@@ -65,7 +65,6 @@
   "configuration.dotnet.projects.enableFileBasedPrograms": "Umožňuje využívat prostředí „programů založených na souborech“ (dotnet run app.cs) ve verzi Preview.",
   "configuration.dotnet.quickInfo.showRemarksInQuickInfo": "Zobrazit informace o poznámkách při zobrazení symbolu.",
   "configuration.dotnet.server.componentPaths": "Umožňuje přepsat cestu ke složce pro integrované komponenty jazykového serveru (například přepsat cestu .roslynDevKit v adresáři rozšíření tak, aby používala místně sestavené komponenty).",
-  "configuration.dotnet.server.componentPaths.razorDevKit": "Přepíše cestu ke složce pro komponentu Razor Dev Kit jazykového serveru",
   "configuration.dotnet.server.componentPaths.razorExtension": "Přepíše cestu ke složce pro komponentu rozšíření Razor jazykového serveru",
   "configuration.dotnet.server.componentPaths.roslynCopilot": "Přepíše cestu ke složce pro komponentu .roslynCopilot jazykového serveru.",
   "configuration.dotnet.server.componentPaths.roslynDevKit": "Přepíše cestu ke složce pro komponentu .roslynDevKit jazykového serveru.",
@@ -125,7 +124,6 @@
   "configuration.omnisharp.useEditorFormattingSettings": "Určuje, jestli má server OmniSharp používat nastavení editoru VS Code pro formátování kódu C# (použití tabulátorů, velikost odsazení).",
   "configuration.omnisharp.useModernNet.description": "Použijte build serveru OmniSharp pro .NET 6. Tato verze _nepodporuje_ projekty .NET Framework, které nejsou ve stylu sady SDK, včetně Unity. U projektů Framework, .NET Core a .NET 5+, které jsou ve stylu sady SDK, byste měli zaznamenat výrazné zlepšení výkonu.",
   "configuration.omnisharp.useModernNet.title": "Použít build serveru OmniSharp pro .NET 6",
-  "configuration.razor.languageServer.cohostingEnabled": "Povolte společné hostování Razor.",
   "configuration.razor.languageServer.debug": "Určuje, jestli se má při spouštění jazykového serveru čekat na připojení ladění.",
   "configuration.razor.languageServer.directory": "Přepíše cestu k adresáři jazykového serveru Razor.",
   "configuration.razor.languageServer.suppressLspErrorToasts": "Potlačí zobrazování informačních zpráv o chybách, pokud na serveru dojde k chybě, ze které se dá zotavit.",
@@ -261,4 +259,4 @@
   "generateOptionsSchema.targetOutputLogPath.description": "Při nastavení této možnosti se text, který cílová aplikace zapisuje do stdout a stderr (např. Console.WriteLine), uloží do zadaného souboru. Tato možnost se bude ignorovat, pokud je konzola nastavená na jinou hodnotu než internalConsole. Příklad: ${workspaceFolder}/out.txt",
   "generateOptionsSchema.type.markdownDescription": "Typ kódu, který se má ladit. Může to být buď coreclr pro ladění .NET Core, nebo cclr pro Desktop .NET Framework. clr funguje pouze v systému Windows, protože Desktop Framework je určen pouze pro Windows.",
   "viewsWelcome.debug.contents": "[Generování prostředků jazyka C# pro sestavení a ladění](command:dotnet.generateAssets)\r\n\r\nDalší informace o souboru launch.json najdete v tématu [Konfigurace souboru launch.json pro ladění v jazyce C#](https://aka.ms/VSCode-CS-LaunchJson)."
-}
+}

package.nls.de.json

@@ -65,7 +65,6 @@
   "configuration.dotnet.projects.enableFileBasedPrograms": "Aktiviert die Vorschau für die Erfahrung „dateibasierte Programme“ (dotnet run app.cs).",
   "configuration.dotnet.quickInfo.showRemarksInQuickInfo": "Beschreibungsinformationen beim Anzeigen des Symbols anzeigen.",
   "configuration.dotnet.server.componentPaths": "Ermöglicht das Überschreiben des Ordnerpfads für eingebaute Komponenten des Sprachservers (z. B. Überschreiben des Pfads .roslynDevKit im Erweiterungsverzeichnis, um lokal erstellte Komponenten zu verwenden)",
-  "configuration.dotnet.server.componentPaths.razorDevKit": "Überschreibt den Ordnerpfad für die Razor-Dev-Kit-Komponente des Sprachservers",
   "configuration.dotnet.server.componentPaths.razorExtension": "Überschreibt den Ordnerpfad für die Razor-Erweiterungskomponente des Sprachservers",
   "configuration.dotnet.server.componentPaths.roslynCopilot": "Überschreibt den Ordnerpfad für die .roslynCopilot-Komponente des Sprachservers",
   "configuration.dotnet.server.componentPaths.roslynDevKit": "Überschreibt den Ordnerpfad für die Komponente .roslynDevKit des Sprachservers",
@@ -125,7 +124,6 @@
   "configuration.omnisharp.useEditorFormattingSettings": "Gibt an, ob OmniSharp VS Code-Editoreinstellungen für C#-Codeformatierung verwenden soll (Verwendung von Registerkarten, Einzugsgröße).",
   "configuration.omnisharp.useModernNet.description": "Verwenden Sie den OmniSharp-Build für .NET 6. Diese Version unterstützt _keine_ .NET Framework-Projekte, die nicht im SDK-Stil vorliegen, einschließlich Unity. Framework-Projekte im SDK-Stil, .NET Core- und .NET 5+-Projekte sollten erhebliche Leistungsverbesserungen aufweisen.",
   "configuration.omnisharp.useModernNet.title": ".NET 6-Build von OmniSharp verwenden",
-  "configuration.razor.languageServer.cohostingEnabled": "Razor-Cohosting aktivieren.",
   "configuration.razor.languageServer.debug": "Gibt an, ob beim Starten des Sprachservers auf die Debuganfügung gewartet werden soll.",
   "configuration.razor.languageServer.directory": "Überschreibt den Pfad zum Razor-Sprachserver-Verzeichnis.",
   "configuration.razor.languageServer.suppressLspErrorToasts": "Unterdrückt, dass Fehler-Popups angezeigt werden, wenn auf dem Server ein wiederherstellbarer Fehler auftritt.",
@@ -261,4 +259,4 @@
   "generateOptionsSchema.targetOutputLogPath.description": "Bei Festlegung wird Text, den die Zielanwendung in \"stdout\" und \"stderr\" (z. B. Console.WriteLine) schreibt, in der angegebenen Datei gespeichert. Diese Option wird ignoriert, wenn die Konsole auf einen anderen Wert als internalConsole festgelegt ist. Beispiel: \"${workspaceFolder}/out.txt\"",
   "generateOptionsSchema.type.markdownDescription": "Geben Sie den Typ des zu debuggenden Codes ein. Dies kann `coreclr` für das .NET Core-Debugging oder `clr` für Desktop .NET Framework sein. `clr` funktioniert nur für Windows, da das Desktopframework nur Windows ist.",
   "viewsWelcome.debug.contents": "[C#-Objekte für Build und Debuggen generieren](command:dotnet.generateAssets)\r\n\r\nWeitere Informationen zu launch.json finden Sie unter [Konfigurieren von launch.json für das C#-Debuggen](https://aka.ms/VSCode-CS-LaunchJson)."
-}
+}

package.nls.es.json

@@ -65,7 +65,6 @@
   "configuration.dotnet.projects.enableFileBasedPrograms": "Habilita la experiencia de vista previa de \"programas basados en archivos\" (dotnet run app.cs).",
   "configuration.dotnet.quickInfo.showRemarksInQuickInfo": "Mostrar información de comentarios cuando se muestra el símbolo.",
   "configuration.dotnet.server.componentPaths": "Permite invalidar la ruta de acceso de carpeta para los componentes integrados del servidor de lenguaje (por ejemplo, invalidar la ruta de acceso .roslynDevKit en el directorio de extensión para usar componentes compilados localmente).",
-  "configuration.dotnet.server.componentPaths.razorDevKit": "Invalida la ruta de acceso de la carpeta para el componente Razor Dev Kit del servidor de lenguaje",
   "configuration.dotnet.server.componentPaths.razorExtension": "Invalida la ruta de acceso de la carpeta para el componente de extensión Razor del servidor de lenguaje",
   "configuration.dotnet.server.componentPaths.roslynCopilot": "Invalida la ruta de acceso de la carpeta para el componente .roslynCopilot del servidor de lenguaje",
   "configuration.dotnet.server.componentPaths.roslynDevKit": "Invalida la ruta de acceso de la carpeta para el componente .roslynDevKit del servidor de lenguaje.",
@@ -125,7 +124,6 @@
   "configuration.omnisharp.useEditorFormattingSettings": "Especifica si OmniSharp debe usar la configuración VS Code del editor para el formato de código de C# (uso de tabulaciones, tamaño de sangría).",
   "configuration.omnisharp.useModernNet.description": "Use la compilación de OmniSharp para .NET 6. Esta versión no admite proyectos de .NET Framework que no sean de tipo SDK, incluido Unity. Los proyectos framework de estilo SDK, .NET Core y .NET 5+ deben ver mejoras significativas en el rendimiento.",
   "configuration.omnisharp.useModernNet.title": "Usar la compilación de .NET 6 de OmniSharp",
-  "configuration.razor.languageServer.cohostingEnabled": "Habilite el cohospedaje de Razor.",
   "configuration.razor.languageServer.debug": "Especifica si se debe esperar a que se adjunte la depuración al iniciar el servidor de lenguaje.",
   "configuration.razor.languageServer.directory": "Invalida la ruta de acceso al directorio del servidor de lenguaje Razor.",
   "configuration.razor.languageServer.suppressLspErrorToasts": "Suprime la visualización de notificaciones del sistema de error si el servidor encuentra un error recuperable.",
@@ -261,4 +259,4 @@
   "generateOptionsSchema.targetOutputLogPath.description": "Cuando se establece, el texto que la aplicación de destino escribe en stdout y stderr (por ejemplo, Console.WriteLine) se guardará en el archivo especificado. Esta opción se omite si la consola se establece en un valor distinto de internalConsole. Por ejemplo, \"${workspaceFolder}/out.txt\"",
   "generateOptionsSchema.type.markdownDescription": "Escriba el tipo de código que se va a depurar. Puede ser \"coreclr\" para la depuración de .NET Core o \"clr\" para desktop .NET Framework. \"clr\" solo funciona en Windows, ya que el marco de trabajo de escritorio es solo de Windows.",
   "viewsWelcome.debug.contents": "[Generar recursos de C# para compilación y depuración](command:dotnet.generateAssets)\r\n\r\nPara obtener más información sobre launch.json, consulte [Configuración de launch.json para la depuración de C#](https://aka.ms/VSCode-CS-LaunchJson)."
-}
+}