Update as per dotnet/arcade#8369

Author: RussKie

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/Application.ParkingWindowTests.cs

@@ -35,7 +35,7 @@ public void ParkingWindow_DoesNotThrowOnGarbageCollecting()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         private Form InitFormWithControlToGarbageCollect()

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewGroup.ListViewGroupAccessibleObjectTests.cs

@@ -285,6 +285,9 @@ public void ListViewGroupAccessibleObject_Bounds_ReturnsCorrectValue()
                 Rectangle expectedBounds = groupRect;
                 Assert.Equal(expectedBounds, actualBounds);
             });
+
+            // verify the remote process succeeded
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         public static IEnumerable<object[]> ListViewGroupAccessibleObject_TestData()

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewGroupTests.cs

@@ -224,7 +224,7 @@ public unsafe void ListViewGroup_TitleImageIndex_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsFact]
@@ -364,7 +364,7 @@ public unsafe void ListViewGroup_TitleImageKey_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]
@@ -504,7 +504,7 @@ public unsafe void ListViewGroup_Subtitle_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]
@@ -616,7 +616,7 @@ public unsafe void ListViewGroup_Footer_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         public static IEnumerable<object[]> Alignment_Set_TestData()
@@ -876,7 +876,7 @@ public unsafe void ListViewGroup_Header_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]
@@ -1142,7 +1142,7 @@ public unsafe void ListViewGroup_Collapse_GetGroupInfo_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]
@@ -1279,7 +1279,7 @@ public unsafe void ListViewGroup_Task_GetGroupInfo_Success()
             });
 
             // Verify the remote process succeeded.
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ListViewTests.cs

@@ -1969,7 +1969,7 @@ public unsafe void ListView_Handle_GetWithGroups_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsFact]
@@ -4575,7 +4575,7 @@ public unsafe void ListView_WmReflectNotify_LVN_KEYDOWN_WithGroups_and_SelectedI
             }, keyString, expectedGroupIndexString);
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsTheory]

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ProfessionalColorTableTests.cs

@@ -199,7 +199,7 @@ public void ProfessionalColorTable_ChangeUserPreferences_GetColor_ReturnsExpecte
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokerHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
     }
 }

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/TaskDialogTests.cs

@@ -13,7 +13,7 @@ public class TaskDialogTests : IClassFixture<ThreadExceptionFixture>
         public void TaskDialog_ShowDialog_SetProperty_SameThread_Success()
         {
             // Run this from another thread as we call Application.EnableVisualStyles.
-            using RemoteInvokeHandle invokeHandle = RemoteExecutor.Invoke(() =>
+            using RemoteInvokeHandle invokerHandle = RemoteExecutor.Invoke(() =>
             {
                 Application.EnableVisualStyles();
                 Control.CheckForIllegalCrossThreadCalls = true;
@@ -30,14 +30,14 @@ public void TaskDialog_ShowDialog_SetProperty_SameThread_Success()
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokeHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
 
         [WinFormsFact]
         public void TaskDialog_ShowDialog_SetProperty_DifferentThread_ThrowsInvalidOperationException()
         {
             // Run this from another thread as we call Application.EnableVisualStyles.
-            using RemoteInvokeHandle invokeHandle = RemoteExecutor.Invoke(() =>
+            using RemoteInvokeHandle invokerHandle = RemoteExecutor.Invoke(() =>
             {
                 Application.EnableVisualStyles();
                 Control.CheckForIllegalCrossThreadCalls = true;
@@ -56,7 +56,7 @@ public void TaskDialog_ShowDialog_SetProperty_DifferentThread_ThrowsInvalidOpera
             });
 
             // verify the remote process succeeded
-            Assert.Equal(0, invokeHandle.ExitCode);
+            Assert.Equal(RemoteExecutor.SuccessExitCode, invokerHandle.ExitCode);
         }
     }
 }