Addressing a bunch of PR comments. Testing if xcopy is needed. Changed the drop hashing logic.

Author: MiYanni

README.md

@@ -16,5 +16,5 @@ This repository contains the version information for .NET SDK Workloads.
   - **Do not** create an AzDO PAT. Leave that entry blank in the darc-authenticate file for it to use local machine auth.
 6. Request access to the [.NET Daily Internal Build Access](https://coreidentity.microsoft.com/manage/Entitlement/entitlement/netdailyinte-q2ql) entitlement
   - This allows the local AzDO machine auth to gather internal assets from AzDO.
-  - ***Message Matt Mitchell*** (@mmitche) for approval after requesting access to the entitlement.
+  - **Send a message** to one of the primary owners on the entitlement page for approval after requesting access to the entitlement.
   - Should take about 20 mins for the entitlement process to complete (will appear on your [entitlements list](https://coreidentity.microsoft.com/manage/entitlement)) and another 30 mins the access to propagate to DARC. Basically, after approval, wait an hour until you actually attempt to build.

eng/create-workload-drops.ps1

@@ -1,3 +1,11 @@
+# Using the downloaded workloads, this creates the VS drops to upload for VS insertion.
+# It builds the Microsoft.NET.Workloads.Vsman.vsmanproj per workload ZIP, which creates the appropriate VSMAN file.
+
+# $workloadPath: The path to the directory containing the workload ZIPs, usually the output path used by DARC in the download-workloads.ps1 script.
+# - Example Value: "$(RepoRoot)artifacts\workloads"
+# $msBuildToolsPath: The path to the MSBuild tools directory, generally $(MSBuildToolsPath) in MSBuild.
+# - Example Value: 'C:\Program Files\Microsoft Visual Studio\2022\Preview\MSBuild\Current\Bin'
+
 param ([Parameter(Mandatory=$true)] [string] $workloadPath, [Parameter(Mandatory=$true)] [string] $msBuildToolsPath)
 
 # Extracts the workload drop zips.
@@ -12,18 +20,23 @@ $null = $workloads | ForEach-Object { Expand-Archive -Path $_.FullName -Destinat
 $dropInfoRegex = '^Workload\.VSDrop\.(?<full>(?<short>\w*)\..*?(?<type>(pre\.)?components$|packs$))'
 $primaryVSComponentJsonValues = ''
 $secondaryVSComponentJsonValues = ''
-$hashAlgorithm = [System.Security.Cryptography.SHA256]::Create()
 Get-ChildItem -Path $workloadDropPath -Directory | ForEach-Object {
   $null = $_.Name -match $dropInfoRegex
   $assemblyName = "$($Matches.full)"
   $dropDir = "$($_.FullName)\"
 
   # Hash the files within the drop folder to create a unique identifier that represents this workload drop.
   # Example: 1E3EA4FE202394037253F57436A6EAD5DE1359792B618B9072014A98563A30FB
-  $fileHashes = [byte[]]@()
+  # See: https://learn.microsoft.com/powershell/module/microsoft.powershell.utility/get-filehash#example-4-compute-the-hash-of-a-string
+  $contentStream = [System.IO.MemoryStream]::new()
+  $writer = [System.IO.StreamWriter]::new($contentStream)
   $dropFiles = Get-ChildItem -Path $dropDir | Sort-Object
-  $null = $dropFiles | Get-Content -Encoding Byte -Raw | ForEach-Object { $fileHashes += $hashAlgorithm.ComputeHash($_) }
-  $dropHash = [System.BitConverter]::ToString($hashAlgorithm.ComputeHash([byte[]]$fileHashes)).Replace('-','')
+  # Note: We're using ASCII because when testing between PS 5.1 and PS 7.5, this would result in the same hash. Other encodings arrived at different hashes.
+  $null = $dropFiles | Get-Content -Encoding ASCII -Raw | ForEach-Object { $writer.Write($_) }
+  $writer.Flush()
+  $contentStream.Position = 0
+  $dropHash = (Get-FileHash -InputStream $contentStream).Hash
+  $writer.Close()
 
   $vsDropName = "Products/dotnet/workloads/$assemblyName/$dropHash"
   # Reads the first line out of the .metadata file in the workload's output folder and sets it to the workload version.
@@ -58,7 +71,7 @@ Get-ChildItem -Path $workloadDropPath -Directory | ForEach-Object {
     }
   }
 
-  Write-Host 'After upload, your workload drop will be available at:'
+  Write-Host '❗ After upload, your workload drop will be available at:'
   Write-Host "https://devdiv.visualstudio.com/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=$vsDropName"
 }
 

eng/download-workloads.ps1

@@ -1,3 +1,18 @@
+# This downloads the workloads using DARC.
+# In CI, we need to pass PATs to this, so it runs in Azure Pipelines only (not through MSBuild).
+# For local builds, some preconfiguration is necessary. Check the README.md for details.
+
+# $workloadPath: The path to the directory as output for the workload ZIPs. This is --output-dir in the DARC command.
+# - Example Value: "$(RepoRoot)artifacts\workloads"
+# $gitHubPat: The GitHub PAT to use for DARC (CI build only). See workload-build.yml for converting the PAT to SecureString.
+# $azDOPat: The Azure DevOps PAT to use for DARC (CI build only). See workload-build.yml for converting the PAT to SecureString.
+# $workloadListJson: The JSON string of the list of workload drop names to download. If not provided, all workloads found in Version.Details.xml will be downloaded.
+# - See the workloadDropNames parameter in official.yml for the list generally passed to this script.
+# - Example Value: '{["emsdk","mono"]}'
+# $usePreComponents:
+# - If $true, includes *pre.components.zip drops and excludes *components.zip drops.
+# - If $false, excludes *pre.components.zip drops and includes *components.zip drops.
+
 param ([Parameter(Mandatory=$true)] [string] $workloadPath, [SecureString] $gitHubPat, [SecureString] $azDOPat, [string] $workloadListJson = '', [bool] $usePreComponents = $false)
 
 ### Local Build ###

eng/pipelines/official.yml

@@ -45,13 +45,14 @@ parameters:
   displayName: Primary VS insertion branches
   type: object
   default:
+  - main
   - rel/d17.12
+  - rel/d17.13
 # These insert packs only into VS [no (pre)components].
 - name: secondaryVsInsertionBranches
   displayName: 'Secondary VS insertion branches [packs only]'
   type: object
-  default:
-  - rel/d17.13
+  default: []
 
 variables:
 # Variables used: DncEngInternalBuildPool

eng/pipelines/templates/jobs/workload-build.yml

@@ -36,7 +36,6 @@ jobs:
         - task: AzureCLI@2
           displayName: 🟣 Download workloads for VS insertion
           inputs:
-            # TODO: Need our own subscription
             azureSubscription: DotNetStaging
             scriptType: pscore
             scriptPath: $(Build.SourcesDirectory)/eng/download-workloads.ps1

global.json

@@ -1,7 +1,6 @@
 {
   "tools": {
-    "dotnet": "9.0.100",
-    "xcopy-msbuild": "17.12.0"
+    "dotnet": "9.0.100"
   },
   "msbuild-sdks": {
     "Microsoft.Build.NoTargets": "3.7.0",