Skip to content

Fix failure in DrtFixedEdit #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ojhad opened this issue Jul 2, 2019 · 0 comments
Closed

Fix failure in DrtFixedEdit #1141

ojhad opened this issue Jul 2, 2019 · 0 comments
Assignees
Labels
Bug Product bug (most likely) regression status: This issue is a regression from a previous build or release
Milestone

Comments

@ojhad
Copy link
Contributor

ojhad commented Jul 2, 2019

DrtFixedEdit is failing because we are currently trying to read the scheme of a relative uri here:

(inputUri.Scheme == PackUriHelper.UriSchemePack && !String.IsNullOrEmpty(inputUri.Fragment)))

This failure was introduced due to changes that were made to the above if statement here:
https://github.com/dotnet/wpf/pull/969/files#diff-d6cd62f214719773a7a26ab93a0235b8

The failure was introduced by removing the CanNavigateToUri method, which was blocking the execution of the following inputUri.Scheme statement for relative URIs.

@grubioe grubioe added this to the 3.0 milestone Jul 2, 2019
@grubioe grubioe added regression status: This issue is a regression from a previous build or release Bug Product bug (most likely) labels Jul 2, 2019
@ojhad ojhad closed this as completed Jul 10, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Product bug (most likely) regression status: This issue is a regression from a previous build or release
Projects
None yet
Development

No branches or pull requests

2 participants