Skip to content

After branching for 5.0, increase the version of WindowsBase to fix incorrect conflict resolution #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagood opened this issue Jul 23, 2019 · 3 comments · Fixed by #1803
Assignees
Labels
area-infrastructure rank20 Rank: Priority/rank on a scale of (1..100)
Milestone

Comments

@dagood
Copy link
Member

dagood commented Jul 23, 2019

In Core-Setup, we're trying to pack up 3.0 WPF assets to deliver as a 5.0 WindowsDesktop shared framework, and hit problems with WindowsBase.dll versioning: https://gist.github.com/dagood/5f328e6148acd7cc8ee1afcc6c60f814.

Basically, CoreFX produces a 5.0 WindowsBase.dll, which wins against WPF's 4.8 WindowsBase.dll, causing conflict resolution to favor CoreFX's--which isn't supposed to happen.

This is a tracking issue to make sure it's fixed.

/cc @ericstj @vatsan-madhavan

@ericstj
Copy link
Member

ericstj commented Jul 23, 2019

To be clear about versions here. AssemblyVersion from corefx is 4.0.0.0, fileversion is 5.a.b.c.

My expectation is that when WPF reversions for 5.0 it will bump AssemblyVersion to 5.0.0.0 and we'll no longer need to worry about synchronizing fileversion anymore.

@vatsan-madhavan vatsan-madhavan added this to the 5.0 milestone Jul 24, 2019
@vatsan-madhavan vatsan-madhavan self-assigned this Jul 24, 2019
@vatsan-madhavan vatsan-madhavan added area-infrastructure rank20 Rank: Priority/rank on a scale of (1..100) labels Jul 24, 2019
@vatsan-madhavan
Copy link
Member

Until WPF forks, wouldn't it make sense to force-back corefx's WindowsBase down to 4.0.0.0 temporarily ?

@ericstj
Copy link
Member

ericstj commented Jul 24, 2019

Not worth it since no one should be trying to consume the WindowsDesktop SDK coming out of core-setup master.

This was referenced Sep 6, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure rank20 Rank: Priority/rank on a scale of (1..100)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants