Skip to content

Is PresentationCore built with Debug configuration? #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
omariom opened this issue Sep 4, 2019 · 1 comment
Closed

Is PresentationCore built with Debug configuration? #1766

omariom opened this issue Sep 4, 2019 · 1 comment

Comments

@omariom
Copy link
Contributor

omariom commented Sep 4, 2019

  • .NET Core Version: 3.0.0-preview8-28405-07, 3.0.0-preview6-27804-01
  • Windows version: 1903
  • Does the bug reproduce also in WPF for .NET Framework 4.8?: No
  • Is this bug related specifically to tooling in Visual Studio (e.g. XAML Designer, Code editing, etc...)? No

Problem description:

While looking at the jitted code of PresentationCore, found that the code was not optimized.
Turned out the assembly has optimizations explicitly disabled.

image

@rladuca
Copy link
Member

rladuca commented Sep 4, 2019

Yep, we discovered this as part of an investigation into #1549. Long story short, we inject a module constructor into PresentationCore via IL(D)Asm and had incorrect settings leading to the wrong parameters being used for the DebuggableAttribute.

This was already fixed recently. Closing as a duplicate.

@rladuca rladuca closed this as completed Sep 4, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants