Skip to content

Thread safety issue in PresentationBuildTasks #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weltkante opened this issue Apr 16, 2019 · 0 comments
Closed

Thread safety issue in PresentationBuildTasks #591

weltkante opened this issue Apr 16, 2019 · 0 comments

Comments

@weltkante
Copy link

During the bugfix for #350 and #378 in PR #570 the static initialization of KnownAssemblyInfoRecord on BamlMapTable was moved into the constructor while keeping the initialized field static. This can lead to potential race conditions when the BamlMapTable is instantiated multiple times on separate threads.

Considering the post-merge comments in the PR its probably safe to make the field an instance field instead of a static field.
@weltkante weltkante mentioned this issue Apr 16, 2019
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weltkante @ryalanms