Skip to content

Public API Requirements : ThemeManager, ThemeMode ?? #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #8538
singhashish-wpf opened this issue Dec 14, 2023 · 0 comments
Open
Tracked by #8538

Public API Requirements : ThemeManager, ThemeMode ?? #8540

singhashish-wpf opened this issue Dec 14, 2023 · 0 comments
Labels
User Story A single user-facing feature. Can be grouped under an epic. Win 11 Theming
Milestone

Comments

@singhashish-wpf
Copy link
Member

singhashish-wpf commented Dec 14, 2023

Description

There are a few public API changes related to theme management for Fluent theme that may be needed in the future, but we are not set on what those APIs should be to make it feature complete.

Currently we have experimental ThemeMode APIs for Application and Window which are only Fluent specific and do not function for other themes. This needs to be changed and we need to find a better way to deal with theme and theme variants.

Previously there has been a lot of discussion on this topic on the following threads :

WPF.UI has the following APIs :

  • ThemeService
  • ApplicationThemeManager
  • SystemThemeManager
  • SystemThemeWatcher
  • ApplicationTheme
  • SystemTheme
  • ThemeChangedEvent
  • IThemeService

WPF may need some or most of these APIs, but that can be discussed only after we finalize the approach on how we are going to use Fluent as default theme.

@singhashish-wpf singhashish-wpf converted this from a draft issue Dec 14, 2023
@dipeshmsft dipeshmsft added the User Story A single user-facing feature. Can be grouped under an epic. label Mar 21, 2024
@dipeshmsft dipeshmsft changed the title Public API Changes ThemeManager, ThemeMode APIs Feb 3, 2025
@dipeshmsft dipeshmsft changed the title ThemeManager, ThemeMode APIs Public API Requirements : ThemeManager, ThemeMode ?? Feb 3, 2025
@dipeshmsft dipeshmsft moved this to Todo in WPF Fluent Theming Feb 3, 2025
@dipeshmsft dipeshmsft added this to the .NET 10 milestone Feb 3, 2025
@dipeshmsft dipeshmsft modified the milestones: .NET 10, 10.0.0 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Story A single user-facing feature. Can be grouped under an epic. Win 11 Theming
Projects
Status: 🥅 Todo
Development

No branches or pull requests

2 participants