Skip to content

Fluent2 ListBoxItem Style (Et al..) Missing Bindings in ControlTemplate #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robert-abeo opened this issue Aug 13, 2024 · 0 comments · Fixed by #9786
Closed

Fluent2 ListBoxItem Style (Et al..) Missing Bindings in ControlTemplate #9564

robert-abeo opened this issue Aug 13, 2024 · 0 comments · Fixed by #9786
Assignees
Labels

Comments

@robert-abeo
Copy link

Description

There are a lot of default styles that don't set template bindings correctly. I give an example for ListBoxItem below but there are other similar cases:

Margin="0"
Padding="{TemplateBinding Padding}"
Background="Transparent"
BorderThickness="1"

Should be:

<Border
  x:Name="Border"
  Padding="{TemplateBinding Padding}"
  Background="{TemplateBinding Background}"
  BorderThickness="{TemplateBinding BorderThickness}"
  CornerRadius="{TemplateBinding Border.CornerRadius}">

The Background/Border properties should be settable on the control itself and carried through to the template. These should NOT be hard-coded.

Reproduction Steps

See current Fluent2 theme

Expected behavior

Control templates should have all applicable template bindings.

Actual behavior

Control templates are missing several template bindings.

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

@robert-abeo robert-abeo changed the title ListBoxItem (Et al..) Missing Bindings in ControlTemplate Fluent2 ListBoxItem Style (Et al..) Missing Bindings in ControlTemplate Aug 13, 2024
@harshit7962 harshit7962 added Bug Product bug (most likely) Win 11 Theming labels Aug 14, 2024
@dipeshmsft dipeshmsft self-assigned this Sep 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants