fix: correctly compare unordered slices

Fixes #2231

Co-authored-by: immanuwell <pchpr.00@list.ru>
Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

Author: drakkan

internal/httpd/internal_test.go

@@ -4317,3 +4317,57 @@ func isSharedProviderSupported() bool {
 		return false
 	}
 }
+
+func TestSlicesEqual(t *testing.T) {
+	tests := []struct {
+		name string
+		s1   []string
+		s2   []string
+		want bool
+	}{
+		{
+			name: "same order",
+			s1:   []string{"read", "write"},
+			s2:   []string{"read", "write"},
+			want: true,
+		},
+		{
+			name: "different order",
+			s1:   []string{"read", "write"},
+			s2:   []string{"write", "read"},
+			want: true,
+		},
+		{
+			name: "different lengths",
+			s1:   []string{"read"},
+			s2:   []string{"read", "write"},
+			want: false,
+		},
+		{
+			name: "same length different values",
+			s1:   []string{"read", "write"},
+			s2:   []string{"read", "delete"},
+			want: false,
+		},
+		{
+			name: "same length different multiplicity",
+			s1:   []string{"read", "write"},
+			s2:   []string{"read", "read"},
+			want: false,
+		},
+		{
+			name: "same multiplicity",
+			s1:   []string{"read", "read", "write"},
+			s2:   []string{"write", "read", "read"},
+			want: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := util.SlicesEqual(tt.s1, tt.s2); got != tt.want {
+				t.Fatalf("SlicesEqual(%v, %v) = %v, want %v", tt.s1, tt.s2, got, tt.want)
+			}
+		})
+	}
+}

internal/util/util.go

@@ -44,7 +44,6 @@ import (
 	"path/filepath"
 	"regexp"
 	"runtime"
-	"slices"
 	"strconv"
 	"strings"
 	"time"
@@ -960,8 +959,15 @@ func SlicesEqual(s1, s2 []string) bool {
 	if len(s1) != len(s2) {
 		return false
 	}
+
+	counts := make(map[string]int)
 	for _, v := range s1 {
-		if !slices.Contains(s2, v) {
+		counts[v]++
+	}
+
+	for _, v := range s2 {
+		counts[v]--
+		if counts[v] < 0 {
 			return false
 		}
 	}