fix(slides): inputs in slides handled correctly #9829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this issue with the latest nightly as there were a'lot of changes with slides lately. |
|
Can you update this PR to resolve conflicts and if you think it is ready to go remove the |
|
Hi, I really appreciate this fix. Is there any update on this? |
|
Ping @jgw96 |
|
updating this |
|
Going to close this PR for now, not entirely happy with the fix here and want to do re-do it from scratch. |
|
Hi, would there be any update or workaround for this issue ? |
|
@jgw96 Any Update on this issue ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Currently the approach here is to treat inputs in slides like they are already in the viewable area. Slides have a complex structure and css that makes it hard for our current input focus scrolling implementation to know how far to scroll, if its in the viewable area etc etc.
Changes proposed in this pull request:
Ionic Version: 2
Fixes: #9553