Skip to content

Commit ab5e7a8

Browse files
committed
chore(rsa): Improve key generation and parsing error handling
1 parent 20893dc commit ab5e7a8

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

crypto/keypair/rsa.go

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,19 @@ func (k *RsaKeyPair) GenKeyPair(size int) error {
7171

7272
if k.Format == PKCS8 {
7373
// PKCS8 format: Use generic headers
74-
privateBytes, _ := x509.MarshalPKCS8PrivateKey(key)
75-
k.PrivateKey = pem.EncodeToMemory(&pem.Block{
76-
Type: "PRIVATE KEY",
77-
Bytes: privateBytes,
78-
})
79-
publicBytes, _ := x509.MarshalPKIXPublicKey(&key.PublicKey)
80-
k.PublicKey = pem.EncodeToMemory(&pem.Block{
81-
Type: "PUBLIC KEY",
82-
Bytes: publicBytes,
83-
})
74+
if privateBytes, err := x509.MarshalPKCS8PrivateKey(key); err == nil {
75+
k.PrivateKey = pem.EncodeToMemory(&pem.Block{
76+
Type: "PRIVATE KEY",
77+
Bytes: privateBytes,
78+
})
79+
}
80+
81+
if publicBytes, err := x509.MarshalPKIXPublicKey(&key.PublicKey); err == nil {
82+
k.PublicKey = pem.EncodeToMemory(&pem.Block{
83+
Type: "PUBLIC KEY",
84+
Bytes: publicBytes,
85+
})
86+
}
8487
}
8588
return nil
8689
}

0 commit comments

Comments
 (0)