Skip to content

collect_traces() is missing a return type #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Jun 26, 2020 · 1 comment · Fixed by #442
Closed

collect_traces() is missing a return type #441

sobolevn opened this issue Jun 26, 2020 · 1 comment · Fixed by #442
Labels
bug Something isn't working

Comments

@sobolevn
Copy link
Member

It should be Iterator[None].
We should also add a typesafety test.

@thepabloaguilar would you please do it? 🙂
@sobolevn sobolevn added the bug Something isn't working label Jun 26, 2020
@thepabloaguilar
Copy link
Member

Yes, I'll do!

This was referenced Jun 27, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds missing return type to collect_traces function thepabloaguilar/returns
2 participants
@sobolevn @thepabloaguilar