-
Notifications
You must be signed in to change notification settings - Fork 229
Description
Hi,
Would there be interest for improving/expanding xSQLServerDatabase, xSQLServerDatabasePermission and xSQLServerDatabaseRole resources?
We currently have a need for the following functionality, which we've covered with custom resources:
- enable snapshot isolation on a DB
create roles on a DBRelated moved to issue SqlDatabaseUser: New resource #846 and BREAKING CHANGE: SqlDatabaseRole: Should only handle database roles and not create database users #847assign permissions to rolesRelated moved to issue BREAKING CHANGE: SqlDatabasePermission: Remove database user creation, and add assigning permission to roles #848
Enabling/disabling snapshot isolation (and perhaps other DB properties) could be added to the xSQLServerDatabase resource.
xSQLServerDatabaseRole is a bit confusing, since it doesn't create/delete roles. Instead, it will create a DB user for a login and assign it an existing role. I think it would be better to have a resource for managing DB roles and a separate resource for user mapping and (maybe) role membership.
xSQLServerDatabasePermission will also add a DB user if it doesn't exist and assign permissions to it. Again, I think we would benefit here from having a separate resource for DB user management and use xSQLServerDatabasePermission to manage permissions on both users and roles.
I'm more than happy to start working on this, but I'd like to hear others' thoughts and ideas.