Skip to content

Commit 9b8bb50

Browse files
committed
Merge virtualfilesystem hook
Add virtual file system settings and hook proc. On index load, clear/set the skip worktree bits based on the virtual file system data. Use virtual file system data to update skip-worktree bit in unpack-trees. Use virtual file system data to exclude files and folders not explicitly requested. The hook was first contributed in private, but was extended via the following pull requests: #15 #27 #33 msysgit#70 Signed-off-by: Ben Peart <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
2 parents d4b2ab9 + 506a4c2 commit 9b8bb50

18 files changed

+887
-7
lines changed

Documentation/config/core.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,14 @@ Version 2 uses an opaque string so that the monitor can return
111111
something that can be used to determine what files have changed
112112
without race conditions.
113113

114+
core.virtualFilesystem::
115+
If set, the value of this variable is used as a command which
116+
will identify all files and directories that are present in
117+
the working directory. Git will only track and update files
118+
listed in the virtual file system. Using the virtual file system
119+
will supersede the sparse-checkout settings which will be ignored.
120+
See the "virtual file system" section of linkgit:githooks[5].
121+
114122
core.trustctime::
115123
If false, the ctime differences between the index and the
116124
working tree are ignored; useful when the inode change time

Documentation/githooks.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -698,6 +698,26 @@ and "0" meaning they were not.
698698
Only one parameter should be set to "1" when the hook runs. The hook
699699
running passing "1", "1" should not be possible.
700700

701+
virtualFilesystem
702+
~~~~~~~~~~~~~~~~~~
703+
704+
"Virtual File System" allows populating the working directory sparsely.
705+
The projection data is typically automatically generated by an external
706+
process. Git will limit what files it checks for changes as well as which
707+
directories are checked for untracked files based on the path names given.
708+
Git will also only update those files listed in the projection.
709+
710+
The hook is invoked when the configuration option core.virtualFilesystem
711+
is set. It takes one argument, a version (currently 1).
712+
713+
The hook should output to stdout the list of all files in the working
714+
directory that git should track. The paths are relative to the root
715+
of the working directory and are separated by a single NUL. Full paths
716+
('dir1/a.txt') as well as directories are supported (ie 'dir1/').
717+
718+
The exit status determines whether git will use the data from the
719+
hook. On error, git will abort the command with an error message.
720+
701721
SEE ALSO
702722
--------
703723
linkgit:git-hook[1]

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1190,6 +1190,7 @@ LIB_OBJS += utf8.o
11901190
LIB_OBJS += varint.o
11911191
LIB_OBJS += version.o
11921192
LIB_OBJS += versioncmp.o
1193+
LIB_OBJS += virtualfilesystem.o
11931194
LIB_OBJS += walker.o
11941195
LIB_OBJS += wildmatch.o
11951196
LIB_OBJS += worktree.o

cache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,7 @@ enum fsync_method {
10741074

10751075
extern enum fsync_method fsync_method;
10761076
extern int core_preload_index;
1077+
extern const char *core_virtualfilesystem;
10771078
extern int core_gvfs;
10781079
extern int precomposed_unicode;
10791080
extern int protect_hfs;

config.c

Lines changed: 43 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1736,7 +1736,11 @@ int git_default_core_config(const char *var, const char *value, void *cb)
17361736
}
17371737

17381738
if (!strcmp(var, "core.sparsecheckout")) {
1739-
core_apply_sparse_checkout = git_config_bool(var, value);
1739+
/* virtual file system relies on the sparse checkout logic so force it on */
1740+
if (core_virtualfilesystem)
1741+
core_apply_sparse_checkout = 1;
1742+
else
1743+
core_apply_sparse_checkout = git_config_bool(var, value);
17401744
return 0;
17411745
}
17421746

@@ -2786,6 +2790,44 @@ int git_config_get_max_percent_split_change(void)
27862790
return -1; /* default value */
27872791
}
27882792

2793+
int git_config_get_virtualfilesystem(void)
2794+
{
2795+
/* Run only once. */
2796+
static int virtual_filesystem_result = -1;
2797+
if (virtual_filesystem_result >= 0)
2798+
return virtual_filesystem_result;
2799+
2800+
if (git_config_get_pathname("core.virtualfilesystem", &core_virtualfilesystem))
2801+
core_virtualfilesystem = getenv("GIT_VIRTUALFILESYSTEM_TEST");
2802+
2803+
if (core_virtualfilesystem && !*core_virtualfilesystem)
2804+
core_virtualfilesystem = NULL;
2805+
2806+
if (core_virtualfilesystem) {
2807+
/*
2808+
* Some git commands spawn helpers and redirect the index to a different
2809+
* location. These include "difftool -d" and the sequencer
2810+
* (i.e. `git rebase -i`, `git cherry-pick` and `git revert`) and others.
2811+
* In those instances we don't want to update their temporary index with
2812+
* our virtualization data.
2813+
*/
2814+
char *default_index_file = xstrfmt("%s/%s", the_repository->gitdir, "index");
2815+
int should_run_hook = !strcmp(default_index_file, the_repository->index_file);
2816+
2817+
free(default_index_file);
2818+
if (should_run_hook) {
2819+
/* virtual file system relies on the sparse checkout logic so force it on */
2820+
core_apply_sparse_checkout = 1;
2821+
virtual_filesystem_result = 1;
2822+
return 1;
2823+
}
2824+
core_virtualfilesystem = NULL;
2825+
}
2826+
2827+
virtual_filesystem_result = 0;
2828+
return 0;
2829+
}
2830+
27892831
int git_config_get_index_threads(int *dest)
27902832
{
27912833
int is_bool, val;

config.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,7 @@ int git_config_get_pathname(const char *key, const char **dest);
615615
int git_config_get_index_threads(int *dest);
616616
int git_config_get_split_index(void);
617617
int git_config_get_max_percent_split_change(void);
618+
int git_config_get_virtualfilesystem(void);
618619

619620
/* This dies if the configured or default date is in the future */
620621
int git_config_get_expiry(const char *key, const char **output);

dir.c

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Junio Hamano, 2005-2006
77
*/
88
#include "cache.h"
9+
#include "virtualfilesystem.h"
910
#include "config.h"
1011
#include "dir.h"
1112
#include "object-store.h"
@@ -1412,6 +1413,17 @@ enum pattern_match_result path_matches_pattern_list(
14121413
int result = NOT_MATCHED;
14131414
size_t slash_pos;
14141415

1416+
/*
1417+
* The virtual file system data is used to prevent git from traversing
1418+
* any part of the tree that is not in the virtual file system. Return
1419+
* 1 to exclude the entry if it is not found in the virtual file system,
1420+
* else fall through to the regular excludes logic as it may further exclude.
1421+
*/
1422+
if (*dtype == DT_UNKNOWN)
1423+
*dtype = resolve_dtype(DT_UNKNOWN, istate, pathname, pathlen);
1424+
if (is_excluded_from_virtualfilesystem(pathname, pathlen, *dtype) > 0)
1425+
return 1;
1426+
14151427
if (!pl->use_cone_patterns) {
14161428
pattern = last_matching_pattern_from_list(pathname, pathlen, basename,
14171429
dtype, pl, istate);
@@ -1755,8 +1767,20 @@ struct path_pattern *last_matching_pattern(struct dir_struct *dir,
17551767
int is_excluded(struct dir_struct *dir, struct index_state *istate,
17561768
const char *pathname, int *dtype_p)
17571769
{
1758-
struct path_pattern *pattern =
1759-
last_matching_pattern(dir, istate, pathname, dtype_p);
1770+
struct path_pattern *pattern;
1771+
1772+
/*
1773+
* The virtual file system data is used to prevent git from traversing
1774+
* any part of the tree that is not in the virtual file system. Return
1775+
* 1 to exclude the entry if it is not found in the virtual file system,
1776+
* else fall through to the regular excludes logic as it may further exclude.
1777+
*/
1778+
if (*dtype_p == DT_UNKNOWN)
1779+
*dtype_p = resolve_dtype(DT_UNKNOWN, istate, pathname, strlen(pathname));
1780+
if (is_excluded_from_virtualfilesystem(pathname, strlen(pathname), *dtype_p) > 0)
1781+
return 1;
1782+
1783+
pattern = last_matching_pattern(dir, istate, pathname, dtype_p);
17601784
if (pattern)
17611785
return pattern->flags & PATTERN_FLAG_NEGATIVE ? 0 : 1;
17621786
return 0;
@@ -2342,6 +2366,8 @@ static enum path_treatment treat_path(struct dir_struct *dir,
23422366
ignore_case);
23432367
if (dtype != DT_DIR && has_path_in_index)
23442368
return path_none;
2369+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, dtype) > 0)
2370+
return path_excluded;
23452371

23462372
/*
23472373
* When we are looking at a directory P in the working tree,
@@ -2546,6 +2572,8 @@ static void add_path_to_appropriate_result_list(struct dir_struct *dir,
25462572
/* add the path to the appropriate result list */
25472573
switch (state) {
25482574
case path_excluded:
2575+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, DT_DIR) > 0)
2576+
break;
25492577
if (dir->flags & DIR_SHOW_IGNORED)
25502578
dir_add_name(dir, istate, path->buf, path->len);
25512579
else if ((dir->flags & DIR_SHOW_IGNORED_TOO) ||

environment.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ int core_apply_sparse_checkout;
7373
int core_sparse_checkout_cone;
7474
int sparse_expect_files_outside_of_patterns;
7575
int core_gvfs;
76+
const char *core_virtualfilesystem;
7677
int merge_log_config = -1;
7778
int precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
7879
unsigned long pack_size_limit_cfg;

hook.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ int run_hooks_opt(const char *hook_name, struct run_hooks_opt *options)
173173
.hook_name = hook_name,
174174
.options = options,
175175
};
176-
const char *const hook_path = find_hook(hook_name);
176+
const char *hook_path = find_hook(hook_name);
177177
int ret = 0;
178178
const struct run_process_parallel_opts opts = {
179179
.tr2_category = "hook",
@@ -189,6 +189,18 @@ int run_hooks_opt(const char *hook_name, struct run_hooks_opt *options)
189189
.data = &cb_data,
190190
};
191191

192+
/*
193+
* Backwards compatibility hack in VFS for Git: when originally
194+
* introduced (and used!), it was called `post-indexchanged`, but this
195+
* name was changed during the review on the Git mailing list.
196+
*
197+
* Therefore, when the `post-index-change` hook is not found, let's
198+
* look for a hook with the old name (which would be found in case of
199+
* already-existing checkouts).
200+
*/
201+
if (!hook_path && !strcmp(hook_name, "post-index-change"))
202+
hook_path = find_hook("post-indexchanged");
203+
192204
if (!options)
193205
BUG("a struct run_hooks_opt must be provided to run_hooks");
194206

read-cache.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
#include "cache.h"
77
#include "gvfs.h"
8+
#include "virtualfilesystem.h"
89
#include "config.h"
910
#include "diff.h"
1011
#include "diffcore.h"
@@ -2070,6 +2071,7 @@ static void post_read_index_from(struct index_state *istate)
20702071
tweak_untracked_cache(istate);
20712072
tweak_split_index(istate);
20722073
tweak_fsmonitor(istate);
2074+
apply_virtualfilesystem(istate);
20732075
}
20742076

20752077
static size_t estimate_cache_size_from_compressed(unsigned int entries)

sparse-index.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,7 @@ void clear_skip_worktree_from_present_files(struct index_state *istate)
497497
int restarted = 0;
498498

499499
if (!core_apply_sparse_checkout ||
500+
core_virtualfilesystem ||
500501
sparse_expect_files_outside_of_patterns)
501502
return;
502503

t/t1090-sparse-checkout-scope.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,9 @@ test_expect_success 'in partial clone, sparse checkout only fetches needed blobs
107107
'
108108

109109
test_expect_success 'checkout does not delete items outside the sparse checkout file' '
110-
# The "sparse.expectfilesoutsideofpatterns" config will prevent the
110+
# The "core.virtualfilesystem" config will prevent the
111111
# SKIP_WORKTREE flag from being dropped on files present on-disk.
112-
test_config sparse.expectfilesoutsideofpatterns true &&
112+
test_config core.virtualfilesystem true &&
113113
114114
test_config core.gvfs 8 &&
115115
git checkout -b outside &&

0 commit comments

Comments
 (0)