fix: return FINISHED when COPY stream ends in Read()

arnoldwakim · arnoldwakim · commit 8a04e90b2e50 · 2026-03-31T23:41:01.000+02:00
diff --git a/src/postgres_binary_reader.cpp b/src/postgres_binary_reader.cpp
@@ -27,13 +27,10 @@ PostgresReadResult PostgresBinaryReader::Read(DataChunk &output) {
 		}
 		FreeBuffer();
 		if (!FetchNextBuffer()) {
-			break;
+			return PostgresReadResult::FINISHED;
 		}
 	}
-	if (output.size() > 0) {
-		return PostgresReadResult::HAVE_MORE_TUPLES;
-	}
-	return PostgresReadResult::FINISHED;
+	return PostgresReadResult::HAVE_MORE_TUPLES;
 }
 
 bool PostgresBinaryReader::FetchNextBuffer() {

Original file line number	Diff line number	Diff line change
`@@ -27,13 +27,10 @@ PostgresReadResult PostgresBinaryReader::Read(DataChunk &output) {`
`27`	`27`	`}`
`28`	`28`	`FreeBuffer();`
`29`	`29`	`if (!FetchNextBuffer()) {`
`30`		`- break;`
	`30`	`+ return PostgresReadResult::FINISHED;`
`31`	`31`	`}`
`32`	`32`	`}`
`33`		`- if (output.size() > 0) {`
`34`		`- return PostgresReadResult::HAVE_MORE_TUPLES;`
`35`		`- }`
`36`		`- return PostgresReadResult::FINISHED;`
	`33`	`+ return PostgresReadResult::HAVE_MORE_TUPLES;`
`37`	`34`	`}`
`38`	`35`
`39`	`36`	`bool PostgresBinaryReader::FetchNextBuffer() {`