Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

DuckPlayer: 31. PoC: Open Player Links in Youtube #3919

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Feb 3, 2025

Task/Issue URL: https://app.asana.com/0/1204099484721401/1209253933548205
Tech Design URL:
CC:

Description:
Open Player links in a clean YouTube view.

Steps to test this PR:

  1. Enable the PoC. (Settings > DuckPlayer > Use Native UI)
  2. Go to Youtube and open a video
  3. Tap the Youtube logo or the video title
  4. Confirm Duck Player is closed and video opens in Youtube in a new tab
  5. Find a video that’s embed protected and open it. (Example)
  6. Confirm DuckPlayer shows the “Video Unavailable” dialog
  7. Tap “Watch in Youtube” link inside the player
  8. Confirm Duck Player is closed and video opens in Youtube in a new tab
  9. Tap the “Watch this video in Youtube” button
  10. Confirm Duck Player is closed and video opens in Youtube in a new tab
  11. Rotate device
  12. Confirm Watch in Youtube Video button is not visible in landscape mode

Definition of Done (Internal Only):

@afterxleep afterxleep requested a review from Bunn February 3, 2025 14:09
@afterxleep afterxleep marked this pull request as ready for review February 3, 2025 14:09
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I’m assuming the iPad is not a concern on this stage of the PoC though. Something to keep in mind on the isLandscape check

Screenshot 2025-02-03 at 17 25 12

@afterxleep afterxleep changed the title DuckPplayer: 31. PoC: Open Player Links in Youtube DuckPlayer: 31. PoC: Open Player Links in Youtube Feb 4, 2025
@afterxleep
Copy link
Collaborator Author

@Bunn Correct. Ipad is out of the picture

@afterxleep afterxleep merged commit 112c7fa into main Feb 4, 2025
18 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer/31.native.poc.3 branch February 4, 2025 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants