This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fix issue on rotating while text selected #3948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
commented
Feb 8, 2025
| @@ -33,11 +33,11 @@ enum UniversalOmniBarState { | |||
| var clearTextOnStart: Bool { baseState.clearTextOnStart } | |||
| var allowsTrackersAnimation: Bool { baseState.allowsTrackersAnimation } | |||
| var showSearchLoupe: Bool { baseState.showSearchLoupe } | |||
| var showCancel: Bool { true } | |||
There was a problem hiding this comment.
The changes here helps with that flicking animation we saw on the simulator.
brindy
approved these changes
Feb 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1209357069596041
Description:
Fix a layout issue when rotating the device while the text was selected
Steps to test this PR:
Definition of Done (Internal Only):