Fix error loading lxs from devcontainer #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert replacing rsync with mutagen
…-in-dts-code-editor-on-mac-devcontainer-DTSW-7328
Tuxliri
deleted the
fix-error-loading-webview-and-security-issue-in-dts-code-editor-on-mac-devcontainer-DTSW-7328
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the local certificate generation process in
setup/mkcert/command.pyto include both thelocalhostdomain and the127.0.0.1IP address. This ensures that the generated SSL certificate is valid for both the domain and the loopback IP, improving compatibility for local development environments.Testing
/workspaces/dt-env-developer/shell/duckietown-shell-commandsdirectory)export DTSHELL_COMMANDS=/workspaces/dt-env-developer/shell/duckietown-shell-commandslx-ros-basic(or any other lx) according to the instructions. Specifically you will want to test that when runningdts code editoryou are able to access the VSCode browser instance that opens.