Skip to content

Commit 7667b6d

Browse files
Fix missing articles in documentation
Co-authored-by: liammcalpineduckietown <[email protected]>
1 parent 7a6aa8e commit 7667b6d

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ dts code start_matrix
120120

121121
You should see the Unity-based Duckiematrix simulator start up.
122122
From here, you can click anywhere on the window and click [ENTER] to make it become active.
123-
Then you change to an overhead view by pressing 'v', which will give you a view that looks like this:
123+
Then you can change to an overhead view by pressing 'v', which will give you a view that looks like this:
124124

125125
![duckiematrix_overhead](assets/duckiematrix_overhead.png)
126126

notebooks/01-Image-Manipulation/braitenberg01.ipynb

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,7 @@
163163
"cell_type": "markdown",
164164
"metadata": {},
165165
"source": [
166-
"In the expression `image1[100:300, 450:550, :]` we selected a part of the image using slice notation. The notation `100:300` means taking the pixels from 100 to 300 in the first coordinate (vertical, starting from top); `450:550` means getting the pixels from 450 to 550 starting in the second coordinate (horizontal, starting from left).\n",
167-
"\n",
168-
"Try updating `image1_cropped` so that it only contains the duckie."
166+
"In the expression `image1[100:300, 450:550, :]` we selected a part of the image using slice notation. The notation `100:300` means taking the pixels from 100 to 300 in the first coordinate (vertical, starting from the top); `450:550` means getting the pixels from 450 to 550 starting in the second coordinate (horizontal, starting from the left).\n\nTry updating `image1_cropped` so that it only contains the duckie."
169167
]
170168
},
171169
{
@@ -247,9 +245,7 @@
247245
"cell_type": "markdown",
248246
"metadata": {},
249247
"source": [
250-
"Note that when we used `image1_copy[128:140, 400:500, 0] = 255` we set the first color channel of a bunch of cells in the array to 255.\n",
251-
"\n",
252-
"We specified those with first (vertical) coordinate 128 to 140 and with second (horizontal) coordinate 400 to 500. Then, the 0 means that we set the first component of the depth: the red color channel."
248+
"Note that when we used `image1_copy[128:140, 400:500, 0] = 255` we set the first color channel of a bunch of cells in the array to 255.\n\nWe specified those with the first (vertical) coordinate 128 to 140 and with the second (horizontal) coordinate 400 to 500. Then, the 0 means that we set the first component of the depth: the red color channel."
253249
]
254250
},
255251
{

notebooks/02-Image-Filtering/braitenberg02.ipynb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@
170170
"id": "88f03111",
171171
"metadata": {},
172172
"source": [
173-
"## Activity\n\nYour task now is to change those numbers above so that we highlight the duckies.\n\n\nWe've created a tool for you to make this easier and suggest you use the following steps:\n\n1. Use [this online color picker](https://pinetools.com/image-color-picker) to click around on the sample images in the `/assets/samples` directory and get familiar with what color corresponds to which HSV values. (You can use any other tool, the link is just for reference). This will set you up to narrow in on the duckie yellow more quickly. **Regardless of the color picker you use, always double-check whether it uses a different convention for HSV ranges. If it does, make sure to convert the result to the OpenCV's convention**.\n\n2. Use the tool [shown in this video](https://vimeo.com/534995276) to find the values interactively. It runs the code in [HSV-bound.py](../../packages/examples/HSV_bound.py) to filter a test image based on the values you choose.\n\n To get this interactive method running, open a terminal on your computer, **navigate to the exercise folder** (where you cloned the `duckietown/lx-braitenberg/` repo) and type:\n\n `dts code build -R ROBOTNAME`\n\n to build your updated exercise on your robot called `ROBOTNAME` (note that it can be virtual or physical as described in the [README](../../README.md)). Then use\n\n `dts code workbench -R ROBOTNAME [-m] -L HSV`\n\n where the `-m` option is used if you have already started the duckiematrix and are using a virtual robot. Then finally start up the VNC desktop with \n\n `dts code vnc -R ROBOTNAME`\n \n to run the HSV tool. In the terminal output you will see lines like the following (you may have to scroll up in the terminal)\n\n ```\n VNC running at http://127.0.0.1:32770\n --------------------------------------------------------\n ```\n\n Following the link will bring up the VNC desktop, where you can click on the HSV activity icon and run the tool.\n\n3. After you have a satisfactory result in the VNC tool, open the file [preprocessing.py](../../packages/solution/preprocessing.py), and change the values of `lower_hsv` and `upper_hsv` to the ones that you found to highlight the duckie. This will be used by your Braitenberg agent in the next notebook."
173+
"## Activity\n\nYour task now is to change those numbers above so that we highlight the duckies.\n\n\nWe've created a tool for you to make this easier and suggest you use the following steps:\n\n1. Use [this online color picker](https://pinetools.com/image-color-picker) to click around on the sample images in the `/assets/samples` directory and get familiar with what color corresponds to which HSV values. (You can use any other tool, the link is just for reference). This will set you up to narrow in on the duckie yellow more quickly. **Regardless of the color picker you use, always double-check whether it uses a different convention for HSV ranges. If it does, make sure to convert the result to OpenCV's convention**.\n\n2. Use the tool [shown in this video](https://vimeo.com/534995276) to find the values interactively. It runs the code in [HSV-bound.py](../../packages/examples/HSV_bound.py) to filter a test image based on the values you choose.\n\n To get this interactive method running, open a terminal on your computer, **navigate to the exercise folder** (where you cloned the `duckietown/lx-braitenberg/` repo) and type:\n\n `dts code build -R ROBOTNAME`\n\n to build your updated exercise on your robot called `ROBOTNAME` (note that it can be virtual or physical as described in the [README](../../README.md)). Then use\n\n `dts code workbench -R ROBOTNAME [-m] -L HSV`\n\n where the `-m` option is used if you have already started the duckiematrix and are using a virtual robot. Then finally start up the VNC desktop with \n\n `dts code vnc -R ROBOTNAME`\n \n to run the HSV tool. In the terminal output you will see lines like the following (you may have to scroll up in the terminal)\n\n ```\n VNC running at http://127.0.0.1:32770\n --------------------------------------------------------\n ```\n\n Following the link will bring up the VNC desktop, where you can click on the HSV activity icon and run the tool.\n\n3. After you have a satisfactory result in the VNC tool, open the file [preprocessing.py](../../packages/solution/preprocessing.py), and change the values of `lower_hsv` and `upper_hsv` to the ones that you found to highlight the duckie. This will be used by your Braitenberg agent in the next notebook."
174174
]
175175
},
176176
{

0 commit comments

Comments
 (0)