Relax minimum php version (#5)

Author: chalasr

.php_cs.dist

@@ -21,7 +21,6 @@ return PhpCsFixer\Config::create()
     ->setRules([
         '@Symfony' => true,
         '@Symfony:risky' => true,
-        'declare_strict_types' => true,
         'header_comment' => [
             'header' => $header,
             'location' => 'after_open',

composer.json

@@ -16,7 +16,7 @@
         }
     ],
     "require": {
-        "php": ">=8.0",
+        "php": ">=7.2.5",
         "symfony/config": "^4.4|^5.2",
         "symfony/dependency-injection": "^4.4|^5.2",
         "symfony/http-kernel": "^4.4|^5.2"

src/Broadcaster/BroadcasterInterface.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Broadcaster;
 
 /**

src/Broadcaster/TwigMercureBroadcaster.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Broadcaster;
 
 use Symfony\Component\Mercure\PublisherInterface;
@@ -40,6 +38,11 @@
  */
 final class TwigMercureBroadcaster implements BroadcasterInterface
 {
+    private $twig;
+    private $messageBus;
+    private $publisher = null;
+    private $expressionLanguage = null;
+
     private const OPTIONS = [
         // Twig options
         'template',
@@ -52,12 +55,16 @@ final class TwigMercureBroadcaster implements BroadcasterInterface
     ];
 
     public function __construct(
-        private Environment $twig,
-        private ?MessageBusInterface $messageBus = null,
-        private ?PublisherInterface $publisher = null,
-        private ?ExpressionLanguage $expressionLanguage = null,
-        private ?string $entityNamespace = null,
+        Environment $twig,
+        ?MessageBusInterface $messageBus = null,
+        ?PublisherInterface $publisher = null,
+        ?ExpressionLanguage $expressionLanguage = null,
+        ?string $entityNamespace = null
     ) {
+        if (80000 > \PHP_VERSION_ID) {
+            throw new \LogicException('The broadcast feature requires PHP 8.0 or greater, you must either upgrade to PHP 8 or disable it.');
+        }
+
         if (null === $this->messageBus && null === $this->publisher) {
             throw new \InvalidArgumentException('A message bus or a publisher must be provided.');
         }
@@ -108,15 +115,17 @@ private function normalizeOptions(object $entity, string $action, array $options
             $options = $this->expressionLanguage->evaluate($options[0], ['entity' => $entity, 'action' => $action]);
         }
 
+        $entityClass = get_class($entity);
+
         if ($extraKeys = array_diff(array_keys($options), self::OPTIONS)) {
-            throw new \InvalidArgumentException(sprintf('Unknown broadcast options "%s" on class "%s". Valid options are: "%s"', implode('", "', $extraKeys), $entity::class, implode('", "', self::OPTIONS)));
+            throw new \InvalidArgumentException(sprintf('Unknown broadcast options "%s" on class "%s". Valid options are: "%s"', implode('", "', $extraKeys), $entityClass, implode('", "', self::OPTIONS)));
         }
 
-        $options['topics'] = (array) ($options['topics'] ?? $entity::class);
+        $options['topics'] = (array) ($options['topics'] ?? $entityClass);
         if (!isset($options['template'])) {
-            $dir = $entity::class;
-            if (null !== $this->entityNamespace && str_starts_with($entity::class, $this->entityNamespace)) {
-                $dir = substr($entity::class, strlen($this->entityNamespace));
+            $dir = $entityClass;
+            if (null !== $this->entityNamespace && 0 !== strpos($entityClass, $this->entityNamespace)) {
+                $dir = substr($entityClass, strlen($this->entityNamespace));
             }
 
             $options['template'] = sprintf('broadcast/%s.stream.html.twig', str_replace('\\', '/', $dir));

src/DependencyInjection/Configuration.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\DependencyInjection;
 
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
@@ -35,7 +33,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                     ->end()
                 ->end()
                 ->arrayNode('broadcast')
-                ->addDefaultsIfNotSet()
+                ->{80000 <= \PHP_VERSION_ID ? 'canBeDisabled' : 'canBeEnabled'}()
                 ->children()
                     ->scalarNode('entity_namespace')->info('Prefix to strip when looking for broadcast templates')->defaultValue('App\\Entity\\')->end()
                 ->end()

src/DependencyInjection/TurboExtension.php

@@ -9,14 +9,13 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\DependencyInjection;
 
 use Doctrine\Bundle\DoctrineBundle\DoctrineBundle;
 use Doctrine\ORM\EntityManagerInterface;
 use Symfony\Bundle\MercureBundle\MercureBundle;
 use Symfony\Bundle\TwigBundle\TwigBundle;
+use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
@@ -38,6 +37,10 @@ public function load(array $configs, ContainerBuilder $container): void
         $loader = (new PhpFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')));
         $loader->load('services.php');
 
+        if ($config['broadcast']['enabled'] && 80000 > \PHP_VERSION_ID) {
+            throw new InvalidConfigurationException('Enabling the "broadcast" config option requires PHP 8 or higher.');
+        }
+
         if (class_exists(TwigBundle::class)) {
             $loader->load('twig.php');
             if (isset($config['mercure']['subscribe_url'])) {
@@ -54,7 +57,7 @@ public function load(array $configs, ContainerBuilder $container): void
             }
         }
 
-        if (class_exists(DoctrineBundle::class) && interface_exists(EntityManagerInterface::class)) {
+        if (class_exists(DoctrineBundle::class) && interface_exists(EntityManagerInterface::class) && 80000 <= \PHP_VERSION_ID) {
             $loader->load('doctrine.php');
         }
     }

src/Doctrine/BroadcastListener.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Doctrine;
 
 use Doctrine\Common\EventArgs;
@@ -30,6 +28,8 @@
  */
 final class BroadcastListener implements ResetInterface
 {
+    private $broadcaster;
+
     /**
      * @var \SplObjectStorage<object, object>
      */
@@ -43,9 +43,12 @@ final class BroadcastListener implements ResetInterface
      */
     private \SplObjectStorage $removedEntities;
 
-    public function __construct(
-        private BroadcasterInterface $broadcaster,
-    ) {
+    public function __construct(BroadcasterInterface $broadcaster)
+    {
+        if (80000 > \PHP_VERSION_ID) {
+            throw new \LogicException('The broadcast feature requires PHP 8.0 or greater, you must either upgrade to PHP 8 or disable it.');
+        }
+
         $this->reset();
     }
 

src/Resources/config/broadcaster.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Symfony\UX\Turbo\Broadcaster\BroadcasterInterface;

src/Resources/config/doctrine.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Symfony\UX\Turbo\Broadcaster\BroadcasterInterface;

src/Resources/config/services.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Symfony\UX\Turbo\Stream\AddTurboStreamFormatSubscriber;

src/Resources/config/twig.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\Component\DependencyInjection\Loader\Configurator;
 
 use Symfony\UX\Turbo\Twig\FrameExtension;

src/Stream/AddTurboStreamFormatSubscriber.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Stream;
 
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
@@ -31,7 +29,7 @@ final class AddTurboStreamFormatSubscriber implements EventSubscriberInterface
     public function onKernelRequest(RequestEvent $event): void
     {
         $request = $event->getRequest();
-        if (!($accept = $request->headers->get('Accept')) || !str_starts_with($accept, TurboStreamResponse::STREAM_MEDIA_TYPE)) {
+        if (!($accept = $request->headers->get('Accept')) || 0 !== strpos($accept, TurboStreamResponse::STREAM_MEDIA_TYPE)) {
             return;
         }
 

src/Stream/TurboStreamResponse.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Stream;
 
 use Symfony\Component\HttpFoundation\Response;

src/Twig/FrameExtension.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Twig;
 
 use Twig\Extension\AbstractExtension;

src/Twig/StreamExtension.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace Symfony\UX\Turbo\Twig;
 
 use Twig\Extension\AbstractExtension;
@@ -31,9 +29,12 @@ final class StreamExtension extends AbstractExtension
         'remove' => true,
     ];
 
-    public function __construct(
-        private ?string $mercureHub = null,
-    ) {}
+    private $mercureHub;
+
+    public function __construct(?string $mercureHub = null)
+    {
+        $this->mercureHub = $mercureHub;
+    }
 
     public function getFunctions(): iterable
     {

tests/BroadcastTest.php

@@ -19,6 +19,8 @@
  * BroadcastTest.
  *
  * @author Kévin Dunglas <[email protected]>
+ *
+ * @requires PHP >= 8.0
  */
 class BroadcastTest extends PantherTestCase
 {

tests/app/Entity/Book.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 namespace App\Entity;
 
 use Doctrine\ORM\Mapping as ORM;

tests/app/public/index.php

@@ -9,8 +9,6 @@
  * file that was distributed with this source code.
  */
 
-declare(strict_types=1);
-
 use App\Kernel;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\HttpFoundation\Request;