Skip to content

Commit b984ee4

Browse files
committed
Make sure that output.path is not undefined since this causes failure within webpack-manifest-plugin
1 parent b1ebfc1 commit b984ee4

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

packages/react-scripts/config/webpack.config.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,10 @@ module.exports = function(webpackEnv) {
170170
].filter(Boolean),
171171
output: {
172172
// The build folder.
173-
path: isEnvProduction ? paths.appBuild : undefined,
173+
// Webpack 5 Change: We will never let this be set to `undefined`.
174+
// TODO: Find out why this was previously conditional.
175+
// See https://github.com/webpack/changelog-v5/blob/master/MIGRATION%20GUIDE.md#cleanup-configuration
176+
path: paths.appBuild,
174177
// Add /* filename */ comments to generated require()s in the output.
175178
pathinfo: isEnvDevelopment,
176179
// There will be one main bundle, and one file per asynchronous chunk.

0 commit comments

Comments
 (0)