fix linter, add indexes for tags

Author: dobrac

packages/api/internal/handlers/template_tags.go

@@ -24,13 +24,15 @@ func (a *APIStore) PostTemplatesTemplateIDTags(c *gin.Context, templateIDOrAlias
 	body, err := utils.ParseBody[api.AssignTemplateTagRequest](ctx, c)
 	if err != nil {
 		a.sendAPIStoreError(c, http.StatusBadRequest, fmt.Sprintf("Invalid request body: %s", err))
+
 		return
 	}
 
 	// Validate tag name
 	if body.Tag == "" {
 		a.sendAPIStoreError(c, http.StatusBadRequest, "Tag name is required")
 		telemetry.ReportError(ctx, "tag name is required", nil)
+
 		return
 	}
 
@@ -50,11 +52,13 @@ func (a *APIStore) PostTemplatesTemplateIDTags(c *gin.Context, templateIDOrAlias
 			}
 			a.sendAPIStoreError(c, http.StatusNotFound, fmt.Sprintf("Template '%s' with tag '%s' not found", templateIDOrAlias, tag))
 			telemetry.ReportError(ctx, "template or source tag not found", err, telemetry.WithTemplateID(templateIDOrAlias))
+
 			return
 		}
 
 		telemetry.ReportError(ctx, "error when getting template with build", err)
 		a.sendAPIStoreError(c, http.StatusInternalServerError, "Error getting template")
+
 		return
 	}
 
@@ -66,6 +70,7 @@ func (a *APIStore) PostTemplatesTemplateIDTags(c *gin.Context, templateIDOrAlias
 	if apiErr != nil {
 		a.sendAPIStoreError(c, apiErr.Code, apiErr.ClientMsg)
 		telemetry.ReportCriticalError(ctx, "error when getting team", apiErr.Err)
+
 		return
 	}
 
@@ -78,6 +83,7 @@ func (a *APIStore) PostTemplatesTemplateIDTags(c *gin.Context, templateIDOrAlias
 	if template.TeamID != team.ID {
 		a.sendAPIStoreError(c, http.StatusForbidden, fmt.Sprintf("You don't have access to sandbox template '%s'", templateIDOrAlias))
 		telemetry.ReportError(ctx, "no access to the template", nil, telemetry.WithTemplateID(template.ID))
+
 		return
 	}
 
@@ -90,6 +96,7 @@ func (a *APIStore) PostTemplatesTemplateIDTags(c *gin.Context, templateIDOrAlias
 	if err != nil {
 		telemetry.ReportCriticalError(ctx, "error when creating tag assignment", err)
 		a.sendAPIStoreError(c, http.StatusInternalServerError, "Error creating tag assignment")
+
 		return
 	}
 
@@ -121,6 +128,7 @@ func (a *APIStore) DeleteTemplatesTemplateIDTagsTag(c *gin.Context, templateIDOr
 	if tag == id.DefaultTag {
 		a.sendAPIStoreError(c, http.StatusBadRequest, fmt.Sprintf("Cannot delete the '%s' tag", id.DefaultTag))
 		telemetry.ReportError(ctx, "cannot delete default tag", nil)
+
 		return
 	}
 
@@ -130,11 +138,13 @@ func (a *APIStore) DeleteTemplatesTemplateIDTagsTag(c *gin.Context, templateIDOr
 		if dberrors.IsNotFoundError(err) {
 			a.sendAPIStoreError(c, http.StatusNotFound, fmt.Sprintf("Template '%s' not found", templateIDOrAlias))
 			telemetry.ReportError(ctx, "template not found", err, telemetry.WithTemplateID(templateIDOrAlias))
+
 			return
 		}
 
 		telemetry.ReportError(ctx, "error when getting template", err)
 		a.sendAPIStoreError(c, http.StatusInternalServerError, "Error getting template")
+
 		return
 	}
 
@@ -143,6 +153,7 @@ func (a *APIStore) DeleteTemplatesTemplateIDTagsTag(c *gin.Context, templateIDOr
 	if apiErr != nil {
 		a.sendAPIStoreError(c, apiErr.Code, apiErr.ClientMsg)
 		telemetry.ReportCriticalError(ctx, "error when getting team", apiErr.Err)
+
 		return
 	}
 
@@ -155,6 +166,7 @@ func (a *APIStore) DeleteTemplatesTemplateIDTagsTag(c *gin.Context, templateIDOr
 	if template.TeamID != team.ID {
 		a.sendAPIStoreError(c, http.StatusForbidden, fmt.Sprintf("You don't have access to sandbox template '%s'", templateIDOrAlias))
 		telemetry.ReportError(ctx, "no access to the template", nil, telemetry.WithTemplateID(template.ID))
+
 		return
 	}
 
@@ -166,6 +178,7 @@ func (a *APIStore) DeleteTemplatesTemplateIDTagsTag(c *gin.Context, templateIDOr
 	if err != nil {
 		telemetry.ReportCriticalError(ctx, "error when deleting tag assignment", err)
 		a.sendAPIStoreError(c, http.StatusInternalServerError, "Error deleting tag assignment")
+		
 		return
 	}
 

…216120000_allow_m_n_builds_with_tags.sql …218160000_allow_m_n_builds_with_tags.sqlpackages/db/migrations/20251216120000_allow_m_n_builds_with_tags.sql renamed to packages/db/migrations/20251218160000_allow_m_n_builds_with_tags.sql packages/db/migrations/20251216120000_allow_m_n_builds_with_tags.sql renamed to packages/db/migrations/20251218160000_allow_m_n_builds_with_tags.sql

@@ -1,4 +1,16 @@
 -- +goose Up
+-- +goose StatementBegin
+-- 0. Create helper function to safely cast text to UUID (returns NULL if invalid)
+-- This is needed for PostgreSQL < 16 (which has pg_input_is_valid)
+CREATE OR REPLACE FUNCTION try_cast_uuid(p_value text) RETURNS uuid AS $$
+BEGIN
+    RETURN p_value::uuid;
+EXCEPTION WHEN invalid_text_representation THEN
+    RETURN NULL;
+END;
+$$ LANGUAGE plpgsql IMMUTABLE;
+-- +goose StatementEnd
+
 -- +goose StatementBegin
 -- 1. Create the new env_build_assignments table
 CREATE TABLE env_build_assignments (
@@ -25,6 +37,13 @@ CREATE TABLE env_build_assignments (
         UNIQUE (build_id, tag, created_at)
 );
 ALTER TABLE "public"."env_build_assignments" ENABLE ROW LEVEL SECURITY;
+
+-- Create indexes for efficient lookups
+CREATE INDEX idx_env_build_assignments_env_tag_created 
+    ON env_build_assignments (env_id, tag, created_at DESC);
+
+CREATE INDEX idx_env_build_assignments_env_build 
+    ON env_build_assignments (env_id, build_id);
 -- +goose StatementEnd
 
 -- +goose StatementBegin
@@ -85,7 +104,18 @@ DROP FUNCTION IF EXISTS sync_env_build_assignment();
 -- +goose StatementEnd
 
 -- +goose StatementBegin
--- 3. Drop the assignments table
+-- 3. Drop indexes
+DROP INDEX IF EXISTS idx_env_build_assignments_env_tag_created;
+DROP INDEX IF EXISTS idx_env_build_assignments_env_build;
+-- +goose StatementEnd
+
+-- +goose StatementBegin
+-- 4. Drop the assignments table
 DROP TABLE IF EXISTS env_build_assignments;
 -- +goose StatementEnd
 
+-- +goose StatementBegin
+-- 5. Drop helper function
+DROP FUNCTION IF EXISTS try_cast_uuid(text);
+-- +goose StatementEnd
+

packages/db/queries/templates/get_template_with_build_by_tag.sql

@@ -19,10 +19,7 @@ JOIN public.env_build_assignments AS eba ON eba.env_id = e.id
         eba.tag = COALESCE(sqlc.narg(tag), 'latest')
         OR
         -- Match by build_id if the tag parameter is a valid UUID
-        (
-            sqlc.narg(tag) IS NOT NULL
-            AND eba.build_id::text = sqlc.narg(tag)
-        )
+        eba.build_id = try_cast_uuid(sqlc.narg(tag))
     )
 JOIN public.env_builds AS eb ON eb.id = eba.build_id
     AND eb.status = 'uploaded'