add comment

dobrac · dobrac · commit 73a2bd22b393 · 2025-11-14T15:09:12.000+01:00
diff --git a/packages/orchestrator/internal/sandbox/network/firewall.go b/packages/orchestrator/internal/sandbox/network/firewall.go
@@ -266,6 +266,7 @@ func addCIDRToSet(conn *nftables.Conn, ipset set.Set, cidr string) error {
 		return err
 	}
 
+	// The checked range is 0.0.0.0 to 255.255.255.254, because when 255.255.255.255 is added, it's then requested as 255.255.255.254.
 	if len(current) == 1 && current[0].AddressRangeStart == netip.MustParseAddr("0.0.0.0") && current[0].AddressRangeEnd == netip.MustParseAddr("255.255.255.254") {
 		// Because 0.0.0.0/0 is not valid IP per GoLang, we can't add new addresses to the set.
 		return nil

Original file line number	Diff line number	Diff line change
`@@ -266,6 +266,7 @@ func addCIDRToSet(conn *nftables.Conn, ipset set.Set, cidr string) error {`
`266`	`266`	`return err`
`267`	`267`	`}`
`268`	`268`
	`269`	`+ // The checked range is 0.0.0.0 to 255.255.255.254, because when 255.255.255.255 is added, it's then requested as 255.255.255.254.`
`269`	`270`	`if len(current) == 1 && current[0].AddressRangeStart == netip.MustParseAddr("0.0.0.0") && current[0].AddressRangeEnd == netip.MustParseAddr("255.255.255.254") {`
`270`	`271`	`// Because 0.0.0.0/0 is not valid IP per GoLang, we can't add new addresses to the set.`
`271`	`272`	`return nil`