Skip to content

--inject-checksum --force incorrectly removes comments from exts_list #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akesandgren opened this issue Oct 3, 2018 · 2 comments
Open
Milestone

Comments

@akesandgren
Copy link
Contributor

akesandgren commented Oct 3, 2018

diff from running inject-checksum --force

 exts_list = [
-    # note: more recent versions of setuptools (v34.x) can not be installed from source anymore,
-    # see https://github.com/pypa/setuptools/issues/980
     ('setuptools', '33.1.1', {
@boegel
Copy link
Member

boegel commented Oct 6, 2018

That may be a tricky one to fix...

There's also a related problem where comments above e.g. sources are getting moved around when --inject-checksums is used.

@boegel boegel added this to the next release milestone Oct 7, 2018
@boegel boegel modified the milestones: 3.8.0, 3.8.1 Nov 20, 2018
@boegel boegel modified the milestones: 3.8.1, 3.9.0 Jan 16, 2019
@boegel boegel modified the milestones: next release (3.9.1), 3.x May 14, 2019
@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
@verdurin
Copy link
Member

I was just bitten by this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants