sync with main + bump version to 5.0.1dev #4825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small improvements to `ModuleLoadEnvironment`
Both branches are identical so the function is no longer required.
Remove superflous `is_string` method
… is now printed in block
…lready prints at info level the stdout and stderr of those commands
The create_unused_dir function distinguishes between the parent directory and the name of the target subdirectory in 2 separate arguments. This interface requires additional parameter management when combined with newer path management interfaces such as pathlib. - Add a function create_unused_dirs accepting the target paths as a single argument. - Support the simultaneous creation of multiple unused paths with all of them having the same suffix if any of the actually requested paths is unavailable.
Packages are be built in some selected build path (--buildpath), and the logs of successful compilation are then concentrated to some other location for permanent storage (--logfile-format). Logs of failed builds remain in the build path location so that they can be inspected. However, this setup is problematic when building software in HPC jobs. Quite often in HPC systems the build path is set to some fast storage local to the node, like NVME raid mounted on `/tmp` or `/dev/shm` (as suggested in the documentation: https://docs.easybuild.io/configuration/#buildpath). The node storage is often wiped out after the end of a job, so the log files and the artifacts are no longer available after the termination of the job. This commit adds options (--log-error-path and --artifact-error-path) to accumulate error logs and artifacts in some more permanent locations, so that the can be easily inspected after a failed build. By default, neither the logs nor the build artifacts are copied in the permanent location.
Flags for persisting logs and artifacts are now checked during the validation of input options. In case of invalid settings the program terminates early with an error. Integration tests for internal logging functions are deactivated as the logging functions are never reached in normal operation.
- Avoid single character variables names outside list comprehension. - Use a consistent pattern in function calls throughout the pull request. - Use context manager to mock stdout and stderr.
…reads on input/output channels
enable non-blocking reads for streaming outputs
When copying logs and artifacts from failed builds, mention the full target path instead of its parent. This reduces the number of actions required to access the artifacts (select, paste, and enter).
Adapt `module show` command run to cope with non-zero exit code for non-existing module (required for Environment Modules v5.5+ and Lmod 8.7.56+)
… lib64 are symlinks to some other path
add extra test case for make_module_req
add BOTH_TO_DIR state to LibSymlink
modernize tests that require GitHub token
clean up easyblocks included in `test_github_xxx_include_easyblocks_from_pr` to avoid breaking other tests
bump version to 5.0.0 + update release notes
…e_pr fix milestone used in `test_github_merge_pr`
release EasyBuild v5.0.0
branfosj
approved these changes
Mar 18, 2025
This was referenced Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.