unpack ResultItem and WorkItem

Author: graingert

Lib/concurrent/futures/process.py

@@ -346,12 +346,29 @@ def run(self):
                 self.terminate_broken(cause)
                 return
             if result_item is not None:
-                self.process_result_item(result_item)
                 exit_pid = result_item.exit_pid
+                work_id = result_item.work_id
+                exception = result_item.exeption
+                result = result_item.result
+                del result_item
+                # Process the received a result_item. This can be either the PID of a
+                # worker that exited gracefully or a _ResultItem
+
+                # Received a _ResultItem so mark the future as completed.
+                work_item = self.pending_work_items.pop(work_id, None)
+                # work_item can be None if another process terminated (see above)
+                if work_item is not None:
+                    f = work_item.future
+                    del work_item
+                    if exception:
+                        f.set_exception(exception)
+                    else:
+                        f.set_result(result)
+                    del f
 
-                # Delete reference to result_item to avoid keeping references
+                # Delete reference to exception/result to avoid keeping references
                 # while waiting on new results.
-                del result_item
+                del exception, result
 
                 process_exited = exit_pid is not None
                 if process_exited:
@@ -435,19 +452,6 @@ def wait_result_broken_or_wakeup(self):
 
         return result_item, is_broken, cause
 
-    def process_result_item(self, result_item):
-        # Process the received a result_item. This can be either the PID of a
-        # worker that exited gracefully or a _ResultItem
-
-        # Received a _ResultItem so mark the future as completed.
-        work_item = self.pending_work_items.pop(result_item.work_id, None)
-        # work_item can be None if another process terminated (see above)
-        if work_item is not None:
-            if result_item.exception:
-                work_item.future.set_exception(result_item.exception)
-            else:
-                work_item.future.set_result(result_item.result)
-
     def is_shutting_down(self):
         # Check whether we should start shutting down the executor.
         executor = self.executor_reference()