Skip to content

Display DevWorkspace warnings when using Devfile 2.0 support #20220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amisevsk opened this issue Jul 28, 2021 · 3 comments
Closed

Display DevWorkspace warnings when using Devfile 2.0 support #20220

amisevsk opened this issue Jul 28, 2021 · 3 comments
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@amisevsk
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

With PR devfile/devworkspace-operator#509, the DevWorkspace operator is adding a warning condition to DevWorkspaces. For now, it is only used for invalid Devfile 2.0 variable replacements, but may be used for more things in the future.

Describe the solution you'd like

If a DevWorkspace has the DevWorkspaceWarning condition with status: true, the Dashboard should grab the message from this condition and display it to the user.

Describe alternatives you've considered

Notify the user that warnings are present and leave it to them to view the condition via the k8s API.

Additional context

Devfile 2.0 Variables DWO issue: devfile/devworkspace-operator#508

@amisevsk amisevsk added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. labels Jul 28, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 28, 2021
@davidfestal davidfestal added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jul 28, 2021
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels Aug 31, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 3, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2022
@amisevsk
Copy link
Contributor Author

amisevsk commented Apr 4, 2022

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2022
@che-bot
Copy link
Contributor

che-bot commented Oct 1, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2022
@che-bot che-bot closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants