Skip to content

Remove deprecated API #874

Open
0 of 7 issues completed
Open
0 of 7 issues completed
@jonahgraham

Description

@jonahgraham

There are a few categories of deprecated API in LSP4J. Most of the @Deprecated annotations are applied to constructs that are deprecated in the LSP and DAP specifications.

Use git grep -p -n -A1 @Deprecated for a quick view of all the deprecated Java with some context.

  • Deprecated items still in LSP/DAP specs (not to be removed)

For example the LSP spec deprecated symbolInformation so it is marked as deprecated in LSP code. I assume cases like this should not be removed from LSP4J as we should keep in LSP4J the same as the spec.

This means not removing deprecated fields and classes in the xtend files and the various service classes (like LanguageServer)

There are numerous constructors in protocol files that are deprecated, such as one of the constructors of WorkspaceEditCapabilities

FormattingOptions getProperties and setProperties were deprecated in #99

Long deprecated and replaced with the more generic JsonRpcData

Items such as all the helper methods in Either seem to be easy decisions to remove

The various factories (like CollectionTypeAdapterFactory) seem to be easy decisions to remove

This was a misspelling and is easy to remove

This was deprecated already in #647 (comment)

Sub-issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions