Skip to content

Commit 1c7f502

Browse files
committed
review comments
Signed-off-by: Jonah Iden <[email protected]>
1 parent ecbf064 commit 1c7f502

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

packages/notebook/src/browser/notebook-editor-widget.tsx

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ export function createNotebookEditorWidgetContainer(parent: interfaces.Container
4343

4444
const NotebookEditorProps = Symbol('NotebookEditorProps');
4545

46+
interface RenderMessage {
47+
rendererId: string;
48+
message: unknown;
49+
}
50+
4651
export interface NotebookEditorProps {
4752
uri: URI,
4853
readonly notebookType: string,
@@ -81,14 +86,14 @@ export class NotebookEditorWidget extends ReactWidget implements Navigatable, Sa
8186
protected readonly onDidChangeModelEmitter = new Emitter<void>();
8287
readonly onDidChangeModel = this.onDidChangeModelEmitter.event;
8388

84-
protected readonly onPostKernelMessageEmitter = new Emitter<unknown>();
85-
readonly onPostKernelMessage = this.onPostKernelMessageEmitter.event;
89+
protected readonly onDidPostKernelMessageEmitter = new Emitter<unknown>();
90+
readonly onDidPostKernelMessage = this.onDidPostKernelMessageEmitter.event;
8691

87-
protected readonly onPostRendererMessageEmitter = new Emitter<{ rendererId: string; message: unknown }>();
92+
protected readonly onPostRendererMessageEmitter = new Emitter<RenderMessage>();
8893
readonly onPostRendererMessage = this.onPostRendererMessageEmitter.event;
8994

90-
protected readonly onDidRecieveKernelMessageEmitter = new Emitter<unknown>();
91-
readonly onDidRecieveKernelMessage = this.onDidRecieveKernelMessageEmitter.event;
95+
protected readonly onDidReceiveKernelMessageEmitter = new Emitter<unknown>();
96+
readonly onDidRecieveKernelMessage = this.onDidReceiveKernelMessageEmitter.event;
9297

9398
protected readonly renderers = new Map<CellKind, CellRenderer>();
9499
protected _model?: NotebookModel;
@@ -176,21 +181,22 @@ export class NotebookEditorWidget extends ReactWidget implements Navigatable, Sa
176181
}
177182

178183
postKernelMessage(message: unknown): void {
179-
this.onPostKernelMessageEmitter.fire(message);
184+
this.onDidPostKernelMessageEmitter.fire(message);
180185
}
181186

182187
postRendererMessage(rendererId: string, message: unknown): void {
183188
this.onPostRendererMessageEmitter.fire({ rendererId, message });
184189
}
185190

186191
recieveKernelMessage(message: unknown): void {
187-
this.onDidRecieveKernelMessageEmitter.fire(message);
192+
this.onDidReceiveKernelMessageEmitter.fire(message);
188193
}
189194

190195
override dispose(): void {
191196
this.onDidChangeModelEmitter.dispose();
192-
this.onPostKernelMessageEmitter.dispose();
193-
this.onDidRecieveKernelMessageEmitter.dispose();
197+
this.onDidPostKernelMessageEmitter.dispose();
198+
this.onDidReceiveKernelMessageEmitter.dispose();
199+
this.onPostRendererMessageEmitter.dispose();
194200
super.dispose();
195201
}
196202
}

packages/plugin-ext/src/main/browser/notebooks/renderers/cell-output-webview.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class CellOutputWebviewImpl implements CellOutputWebview, Disposable {
9898
}));
9999

100100
if (this.editor) {
101-
this.toDispose.push(this.editor.onPostKernelMessage(message => {
101+
this.toDispose.push(this.editor.onDidPostKernelMessage(message => {
102102
this.webviewWidget.sendMessage({
103103
type: 'customKernelMessage',
104104
message

packages/plugin-ext/src/plugin/notebook/notebook-kernels.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class NotebookKernelsExtImpl implements NotebookKernelsExt {
9898
extensionId: extension.id,
9999
extensionLocation: toUriComponents(extension.packageUri),
100100
label: label || extension.id,
101-
preloads: rendererScripts ? rendererScripts.map(preload => ({ uri: toUriComponents(preload.uri.toString()), provides: preload.provides })) : []
101+
preloads: rendererScripts?.map(preload => ({ uri: toUriComponents(preload.uri.toString()), provides: preload.provides })) ?? []
102102
};
103103

104104
//

0 commit comments

Comments
 (0)