ios-browser/swiftlint_baseline.json at main · ecosia/ios-browser · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
[
    {
        "violation": {
            "severity": "warning",
            "reason": "nonisolated modifier should come before private",
            "ruleIdentifier": "modifier_order",
            "ruleName": "Modifier Order",
            "location": {
                "file": "BrowserKit/Sources/TabDataStore/TabDataStore.swift",
                "line": 256,
                "character": 25
            },
            "ruleDescription": "Modifier order should be consistent."
        },
        "text": "    private nonisolated func windowUUID(fromURL url: URL) -> WindowUUID? {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Header comments should be consistent with project patterns",
            "ruleIdentifier": "file_header",
            "ruleName": "File Header",
            "location": {
                "file": "firefox-ios/Client/AdjustHelper.swift",
                "line": 1,
                "character": 1
            },
            "ruleDescription": "Header comments should be consistent with project patterns. The SWIFTLINT_CURRENT_FILENAME placeholder can optionally be used in the required and forbidden patterns. It will be replaced by the real file name."
        },
        "text": ""
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Header comments should be consistent with project patterns",
            "ruleIdentifier": "file_header",
            "ruleName": "File Header",
            "location": {
                "file": "firefox-ios/Client/AdjustTelemetryHelper.swift",
                "line": 1,
                "character": 1
            },
            "ruleDescription": "Header comments should be consistent with project patterns. The SWIFTLINT_CURRENT_FILENAME placeholder can optionally be used in the required and forbidden patterns. It will be replaced by the real file name."
        },
        "text": ""
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "expected 48, got 12",
            "ruleIdentifier": "closure_end_indentation",
            "ruleName": "Closure End Indentation",
            "location": {
                "file": "firefox-ios/Client/Frontend/Library/Bookmarks/BookmarksViewController.swift",
                "line": 190,
                "character": 13
            },
            "ruleDescription": "Closure end should have the same indentation as the line that started it."
        },
        "text": "            }"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "expected 48, got 12",
            "ruleIdentifier": "closure_end_indentation",
            "ruleName": "Closure End Indentation",
            "location": {
                "file": "firefox-ios/Client/Frontend/Library/Bookmarks/Legacy/LegacyBookmarksPanel.swift",
                "line": 294,
                "character": 13
            },
            "ruleDescription": "Closure end should have the same indentation as the line that started it."
        },
        "text": "            }"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Header comments should be consistent with project patterns",
            "ruleIdentifier": "file_header",
            "ruleName": "File Header",
            "location": {
                "file": "firefox-ios/Client/Telemetry/Wrapper/AdjustWrapper.swift",
                "line": 1,
                "character": 1
            },
            "ruleDescription": "Header comments should be consistent with project patterns. The SWIFTLINT_CURRENT_FILENAME placeholder can optionally be used in the required and forbidden patterns. It will be replaced by the real file name."
        },
        "text": ""
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Images that provide context should have an accessibility label or should be explicitly hidden from accessibility",
            "ruleIdentifier": "accessibility_label_for_image",
            "ruleName": "Accessibility Label for Image",
            "location": {
                "file": "firefox-ios/Ecosia/UI/NTP/Header/EcosiaAISearchButton.swift",
                "line": 25,
                "character": 13
            },
            "ruleDescription": "Images that provide context should have an accessibility label or should be explicitly hidden from accessibility"
        },
        "text": "            Image(\"ai-sparkle\", bundle: .ecosia)"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space after generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/Shared/Extensions/OptionalExtensions.swift",
                "line": 16,
                "character": 20
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "public func ??? <T> (optional: T?, defaultValue: @autoclosure () -> String) -> String {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/ClientTests/DateGroupedTableDataTests.swift",
                "line": 113,
                "character": 44
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testCustomIntervalsItemsForSection () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Header comments should be consistent with project patterns",
            "ruleIdentifier": "file_header",
            "ruleName": "File Header",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/ClientTests/Helpers/AdjustTelemetryHelperTests.swift",
                "line": 1,
                "character": 1
            },
            "ruleDescription": "Header comments should be consistent with project patterns. The SWIFTLINT_CURRENT_FILENAME placeholder can optionally be used in the required and forbidden patterns. It will be replaced by the real file name."
        },
        "text": ""
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/L10nSnapshotTests/L10nSuite1SnapshotTests.swift",
                "line": 78,
                "character": 32
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testWebViewContextMenu () throws {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 45,
                "character": 28
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func allowNotifications () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 88,
                "character": 28
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncHistory () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 98,
                "character": 38
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncPageUsingChinaFxA () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 111,
                "character": 29
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncBookmark () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 125,
                "character": 36
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncBookmarkDesktop () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 135,
                "character": 25
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncTabs () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 159,
                "character": 27
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncLogins () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 181,
                "character": 35
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncHistoryDesktop () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 193,
                "character": 36
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncPasswordDesktop () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/IntegrationTests.swift",
                "line": 216,
                "character": 32
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func testFxASyncTabsDesktop () {"
    },
    {
        "violation": {
            "severity": "warning",
            "reason": "Superfluous space between function name and generic parameter(s)",
            "ruleIdentifier": "function_name_whitespace",
            "ruleName": "Function Name Whitespace",
            "location": {
                "file": "firefox-ios/firefox-ios-tests/Tests/XCUITests/LoginsTests.swift",
                "line": 331,
                "character": 21
            },
            "ruleDescription": "There should be consistent whitespace before and after function names and generic parameters."
        },
        "text": "    func closeURLBar () {"
    }
]