Fix top-level build group to not include the compiler and fixup headers. (flutter#66)

Targets in the engine had to individually depend on each sub-target in Impeller when all they cared about was all the client libs. The compiler is a build time implicit dependency. So that has been removed from the top-level group.

Also fixed all the headers so that TUs within Impeller don't care about where Impeller itself sits in the source tree.

Author: chinmaygarde

impeller/BUILD.gn

@@ -3,14 +3,9 @@
 # found in the LICENSE file.
 
 config("impeller_public_config") {
-  include_dirs = [
-    "..",
-    ".",
-  ]
+  include_dirs = [ ".." ]
 }
 
-is_host = is_mac || is_linux || is_win
-
 group("impeller") {
   public_deps = [
     "aiks",
@@ -24,10 +19,6 @@ group("impeller") {
     "tessellator",
     "typographer",
   ]
-
-  if (is_host) {
-    public_deps += [ "compiler" ]
-  }
 }
 
 executable("impeller_unittests") {

impeller/aiks/image.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/aiks/image.h"
+#include "impeller/aiks/image.h"
 
 namespace impeller {
 

impeller/aiks/picture_recorder.cc

@@ -2,9 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/aiks/picture_recorder.h"
+#include "impeller/aiks/picture_recorder.h"
 
-#include "flutter/impeller/aiks/canvas.h"
+#include "impeller/aiks/canvas.h"
 
 namespace impeller {
 

impeller/base/validation.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/base/validation.h"
+#include "impeller/base/validation.h"
 
 #include "flutter/fml/logging.h"
 

impeller/compiler/compiler.cc

@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/compiler/compiler.h"
+#include "impeller/compiler/compiler.h"
 
 #include <filesystem>
 #include <memory>
 #include <sstream>
 
 #include "flutter/fml/paths.h"
-#include "flutter/impeller/compiler/logger.h"
+#include "impeller/compiler/logger.h"
 
 namespace impeller {
 namespace compiler {

impeller/compiler/compiler.h

@@ -10,8 +10,8 @@
 
 #include "flutter/fml/macros.h"
 #include "flutter/fml/mapping.h"
-#include "flutter/impeller/compiler/include_dir.h"
-#include "flutter/impeller/compiler/reflector.h"
+#include "impeller/compiler/include_dir.h"
+#include "impeller/compiler/reflector.h"
 #include "shaderc/shaderc.hpp"
 #include "third_party/spirv_cross/spirv_msl.hpp"
 #include "third_party/spirv_cross/spirv_parser.hpp"

impeller/compiler/compiler_unittests.cc

@@ -2,10 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/compiler/compiler.h"
 #include "flutter/testing/testing.h"
 #include "gtest/gtest.h"
 #include "impeller/base/validation.h"
+#include "impeller/compiler/compiler.h"
 
 namespace impeller {
 namespace compiler {

impeller/compiler/impellerc_main.cc

@@ -8,9 +8,9 @@
 #include "flutter/fml/file.h"
 #include "flutter/fml/macros.h"
 #include "flutter/fml/mapping.h"
-#include "flutter/impeller/compiler/compiler.h"
-#include "flutter/impeller/compiler/switches.h"
-#include "flutter/impeller/compiler/utilities.h"
+#include "impeller/compiler/compiler.h"
+#include "impeller/compiler/switches.h"
+#include "impeller/compiler/utilities.h"
 #include "third_party/shaderc/libshaderc/include/shaderc/shaderc.hpp"
 
 namespace impeller {

impeller/compiler/reflector.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/compiler/reflector.h"
+#include "impeller/compiler/reflector.h"
 
 #include <atomic>
 #include <optional>
@@ -11,12 +11,12 @@
 
 #include "flutter/fml/closure.h"
 #include "flutter/fml/logging.h"
-#include "flutter/impeller/compiler/code_gen_template.h"
-#include "flutter/impeller/compiler/utilities.h"
-#include "flutter/impeller/geometry/matrix.h"
-#include "flutter/impeller/geometry/scalar.h"
 #include "impeller/base/strings.h"
 #include "impeller/base/validation.h"
+#include "impeller/compiler/code_gen_template.h"
+#include "impeller/compiler/utilities.h"
+#include "impeller/geometry/matrix.h"
+#include "impeller/geometry/scalar.h"
 
 namespace impeller {
 namespace compiler {

impeller/compiler/switches.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "flutter/impeller/compiler/switches.h"
+#include "impeller/compiler/switches.h"
 
 #include <filesystem>
 #include <map>