Skip to content

Linting stage in the CI failed #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
v1v opened this issue Dec 17, 2021 · 2 comments · Fixed by #77
Closed

Linting stage in the CI failed #76

v1v opened this issue Dec 17, 2021 · 2 comments · Fixed by #77

Comments

@v1v
Copy link
Member

v1v commented Dec 17, 2021

Linting failed with:

[2021-12-16T17:45:07.296Z] 14 files would be left unchanged.
[2021-12-16T17:45:07.296Z] nox > flake8 --ignore=E501,W503 noxfile.py tests/ ecs_logging/
[2021-12-16T17:45:08.243Z] nox > mypy --strict --show-error-codes --no-warn-unused-ignores ecs_logging/
[2021-12-16T17:45:10.160Z] ecs_logging/_stdlib.py:115: error: Argument "style" to "__init__" of "Formatter" has incompatible type "str"; expected "Union[Literal['%'], Literal['{'], Literal['$']]"  [arg-type]
[2021-12-16T17:45:10.160Z] Found 1 error in 1 file (checked 5 source files)
[2021-12-16T17:45:10.160Z] nox > Command mypy --strict --show-error-codes --no-warn-unused-ignores ecs_logging/ failed with exit code 1
[2021-12-16T17:45:10.160Z] nox > Session lint failed.
script returned exit code 1
@v1v
Copy link
Member Author

v1v commented Dec 17, 2021

See #75

@basepi
Copy link
Contributor

basepi commented Jan 5, 2022

This is due to an upstream change. I'm exploring solutions here: #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants