Skip to content

flit_core requirement #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MiladHeydariaan opened this issue Apr 28, 2023 · 5 comments · Fixed by #94
Closed

flit_core requirement #93

MiladHeydariaan opened this issue Apr 28, 2023 · 5 comments · Fixed by #94

Comments

@MiladHeydariaan
Copy link

Hi,
Is there a reason why ecs-logging-python cannot use flit_core 3.x?
I'm having trouble with depending on flit_core 2.x as it is conflicting with our packages.
Thanks

@basepi
Copy link
Contributor

basepi commented Apr 28, 2023

Good question. @sethmlarson do you happen to remember? Otherwise I can look into this.

@sethmlarson
Copy link
Contributor

sethmlarson commented Apr 28, 2023

flit_core is a built-time dependency, not a runtime dependency, and there shouldn't be any potential for conflicts between packages that have different build-time dependencies. How are you seeing an error in this case?

@MiladHeydariaan
Copy link
Author

We have build-time dependency conflict because our monorepo build structure is using a different version of flit_core (3+) which happens to be on the dependency graph when I try to build ecs-logging-python.

@MiladHeydariaan
Copy link
Author

I patched the version requirement to allow flit_core 3.x and it seems working fine so far. I'm using elasticsearch curator which depends on ecs-logging-python.

@basepi
Copy link
Contributor

basepi commented May 2, 2023

As far as I can tell, flit_core 3.0 only had breaking changes that don't affect us.

I don't see any problem with allowing 3.0+. Any objections @sethmlarson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants