[STORE] Raise NotImplementedError if administrative index methods are called on a Repository class

Author: estolfo

elasticsearch-persistence/lib/elasticsearch/persistence/repository.rb

@@ -18,8 +18,8 @@ module Repository
       include Elasticsearch::Model::Indexing::ClassMethods
 
       def self.included(base)
-        base.send(:extend, ClassMethods)
         base.send(:extend, Elasticsearch::Model::Indexing::ClassMethods)
+        base.send(:extend, ClassMethods)
       end
 
       # These methods are necessary to define at the class-level so that the methods available
@@ -75,6 +75,28 @@ def klass(_class = nil)
         def client(_client = nil)
           @client ||= (_client || Elasticsearch::Transport::Client.new)
         end
+
+        def create_index!(*args)
+          raise_not_implemented_error(__method__)
+        end
+
+        def delete_index!(*args)
+        raise_not_implemented_error(__method__)
+        end
+
+        def refresh_index!(*args)
+          raise_not_implemented_error(__method__)
+        end
+
+        def index_exists?(*args)
+          raise_not_implemented_error(__method__)
+        end
+
+        private
+
+        def raise_not_implemented_error(_method_)
+          raise NotImplementedError, "The '#{_method_}' method is not implemented at the Repository class-level."
+        end
       end
 
       # The default index name.

elasticsearch-persistence/spec/repository_spec.rb

@@ -99,10 +99,6 @@ class NoteRepository
       end
     end
 
-    after do
-      begin; NoteRepository.delete_index!; rescue; end
-    end
-
     context '#client' do
 
       it 'allows the value to be set only once' do
@@ -218,13 +214,10 @@ class NoteRepository
           DEFAULT_REPOSITORY.class
         end
 
-        before do
-          begin; repository.delete_index!; rescue; end
-          repository.create_index!
-        end
-
-        it 'creates the index' do
-          expect(repository.index_exists?).to be(true)
+        it 'raises a NotImplementedError' do
+          expect {
+            repository.create_index!
+          }.to raise_exception(NotImplementedError)
         end
       end
     end
@@ -253,13 +246,10 @@ class NoteRepository
           DEFAULT_REPOSITORY.class
         end
 
-        before do
-          begin; repository.delete_index!; rescue; end
-          repository.create_index!
-        end
-
-        it 'creates the index' do
-          expect(repository.index_exists?).to be(true)
+        it 'raises a NotImplementedError' do
+          expect {
+            repository.delete_index!
+          }.to raise_exception(NotImplementedError)
         end
       end
     end
@@ -287,12 +277,10 @@ class NoteRepository
           DEFAULT_REPOSITORY.class
         end
 
-        before do
-          repository.create_index!
-        end
-
-        it 'creates the index' do
-          expect(repository.refresh_index!['_shards']).to be_a(Hash)
+        it 'raises a NotImplementedError' do
+          expect {
+            repository.refresh_index!
+          }.to raise_exception(NotImplementedError)
         end
       end
     end
@@ -320,12 +308,10 @@ class NoteRepository
           DEFAULT_REPOSITORY.class
         end
 
-        before do
-          repository.create_index!
-        end
-
-        it 'creates the index' do
-          expect(repository.index_exists?).to be(true)
+        it 'raises a NotImplementedError' do
+          expect {
+            repository.index_exists?
+          }.to raise_exception(NotImplementedError)
         end
       end
     end