Elasticsearch::Persistence index is overwritten by newly instantiated classes

[JonathanKolnik]

split_test_repository.rb

class SplitTestRepository
  include Elasticsearch::Persistence::Repository

  def initialize(test_name, options={})
    index test_name
  end
end

rails console

[15] pry(main)> repo_1 = SplitTestRepository.new('repo_1');
[16] pry(main)> repo_1.index
=> "repo_1"
[17] pry(main)> repo_2 = SplitTestRepository.new('repo_2');
[18] pry(main)> repo_2.index
=> "repo_2"
[19] pry(main)> repo_1.index
=> "repo_2"

Is index a class variable? That seems weird. I don't understand why by instantiating repo_2, repo_1.index now points to repo_2's index

I followed this example https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/README.md#a-custom-class

[karmi]

@JonathanKolnik Hey, I see you've closed the issue -- how did you solve it? It looks like incorrect instructions or a bug in the library indeed.

[JonathanKolnik]

@karmi I chickened out and thought I hadn't explored it enough.

repo_1 = SplitTestRepository.new('repo_1')
=> #<SplitTestRepository:0x0000001a042788
 @gateway=
  #<Elasticsearch::Persistence::Repository::Class:0x0000001b11ed40

repo_2 = SplitTestRepository.new('repo_2')
=> #<SplitTestRepository:0x0000001a17af10
 @gateway=
  #<Elasticsearch::Persistence::Repository::Class:0x0000001b11ed40

I think this might be related. Note, @gateway matches. When I use this example https://github.com/elastic/elasticsearch-rails/tree/master/elasticsearch-persistence#the-default-class I don't see the issue.

[karmi]

@JonathanKolnik Yeah, I tried it briefly and I think it's a bug, labelling appropriately...

[dimroc]

+1

[MMartyn]

@karmi I started to look into this and I am not quite sure how you would want to proceed with this bug. The problem seems to stem from the gateway being made a class method:
https://github.com/elastic/elasticsearch-rails/blob/master/elasticsearch-persistence/lib/elasticsearch/persistence/repository.rb#L46
I started to change it, but then quickly realized that there are tests specifically looking for that behavior.

[estolfo]

same issue as this one: #811

[estolfo]

@MMartyn @JonathanKolnik @dimroc
6.0.0.pre versions are available of elasticsearch-rails, elasticsearch-model, and elasticsearch-persistence. They include a refactor so that this problem should be resolved. Feel free to try it out in your testing environment.

[estolfo]

I'm closing this as 6.0.0 is released and it includes a fix for this.