Fix clippy warnings

Author: swallez

api_generator/Cargo.toml

@@ -38,3 +38,6 @@ void = "1"
 
 [dev-dependencies]
 tempfile = "3.12"
+
+[lints.clippy]
+uninlined_format_args = "allow" # too pedantic

api_generator/src/generator/code_gen/request/request_builder.rs

@@ -154,7 +154,7 @@ impl<'a> RequestBuilder<'a> {
                 }
             });
 
-            let query_ctor = endpoint_params.iter().map(|(param_name, _)| {
+            let query_ctor = endpoint_params.keys().map(|param_name| {
                 let field_name = ident(valid_name(param_name).to_lowercase());
                 quote! {
                     #field_name: self.#field_name

elasticsearch/Cargo.toml

@@ -62,3 +62,7 @@ xml-rs = "0.8"
 
 [build-dependencies]
 rustc_version = "0.4"
+
+[lints.clippy]
+needless_lifetimes = "allow" # generated lifetimes
+uninlined_format_args = "allow" # too pedantic

elasticsearch/src/http/transport.rs

@@ -485,7 +485,7 @@ impl Transport {
     /// [Elasticsearch service in Elastic Cloud](https://www.elastic.co/cloud/).
     ///
     /// * `cloud_id`: The Elastic Cloud Id retrieved from the cloud web console, that uniquely
-    ///               identifies the deployment instance.
+    ///   identifies the deployment instance.
     /// * `credentials`: A set of credentials the client should use to authenticate to Elasticsearch service.
     pub fn cloud(cloud_id: &str, credentials: Credentials) -> Result<Transport, Error> {
         let conn_pool = CloudConnectionPool::new(cloud_id)?;

elasticsearch/src/lib.rs

@@ -50,7 +50,7 @@
 //! - **native-tls** *(enabled by default)*: Enables TLS functionality provided by `native-tls`.
 //! - **rustls-tls**: Enables TLS functionality provided by `rustls`.
 //! - **beta-apis**: Enables beta APIs. Beta APIs are on track to become stable and permanent features. Use them with
-//!    caution because it is possible that breaking changes are made to these APIs in a minor version.
+//!   caution because it is possible that breaking changes are made to these APIs in a minor version.
 //! - **experimental-apis**: Enables experimental APIs. Experimental APIs are just that - an experiment. An experimental
 //!   API might have breaking changes in any future version, or it might even be removed entirely. This feature also
 //!   enables `beta-apis`.

xtask/Cargo.toml

@@ -15,3 +15,6 @@ chrono = { version = "0.4", features = ["serde"] }
 zip = "2"
 regex = "1"
 xshell = "0.2"
+
+[lints.clippy]
+uninlined_format_args = "allow" # too pedantic

yaml_test_runner/src/generator.rs

@@ -425,7 +425,7 @@ pub fn generate_tests_from_yaml(
                     error!(
                         "skipping {}. cannot read as Yaml struct: {}",
                         relative_path.to_slash_lossy(),
-                        result.err().unwrap().to_string()
+                        result.err().unwrap()
                     );
                     continue;
                 }